Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database/sql: DB documentation should mention DB.Conn() #25330

Closed
AlekSi opened this issue May 10, 2018 · 2 comments
Closed

database/sql: DB documentation should mention DB.Conn() #25330

AlekSi opened this issue May 10, 2018 · 2 comments

Comments

@AlekSi
Copy link
Contributor

@AlekSi AlekSi commented May 10, 2018

https://golang.org/pkg/database/sql/#DB currently states:

If the database has a concept of per-connection state, such state can only be reliably observed within a transaction.

This is no longer true: DB.Conn() was added to allow one to have a per-connection state without using transactions. DB documentation should be updated.

@kardianos
Copy link
Contributor

@kardianos kardianos commented May 11, 2018

Sounds good

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 6, 2018

Change https://golang.org/cl/116596 mentions this issue: database: update doc related to per-connaction state

@gopherbot gopherbot closed this in 9e4c344 Jun 6, 2018
@golang golang locked and limited conversation to collaborators Jun 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.