Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: uint64(Float32bits(f)) on amd64 doesn't clear high bits [1.10 backport] #25335

Closed
gopherbot opened this issue May 10, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@gopherbot
Copy link

commented May 10, 2018

@josharian requested issue #25322 to be considered for backport to the next 1.10 minor release.

@gopherbot please consider this for backport to 1.10, it results in incorrect code generation.

@rsc

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2018

Please make sure this is included in 1.10.4. Thanks.

@gopherbot

This comment has been minimized.

Copy link
Author

commented Aug 24, 2018

Change https://golang.org/cl/131276 mentions this issue: [release-branch.go1.10] cmd/compile: fix zero extend after float->int conversion

gopherbot pushed a commit that referenced this issue Aug 24, 2018

[release-branch.go1.10] cmd/compile: fix zero extend after float->int…
… conversion

Don't do direct loads from argument slots if the sizes don't match.
This prevents us from loading from a float32 using a uint64 load
during expressions like uint64(math.float32Bits(f)) where f is a float32 arg.

Fixes #25335

Change-Id: I3887d76f78c844ba546243e7721d811c3d4a9700
Reviewed-on: https://go-review.googlesource.com/112637
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-on: https://go-review.googlesource.com/131276
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot

This comment has been minimized.

Copy link
Author

commented Aug 24, 2018

Closed by merging 305b0de to release-branch.go1.10.

@gopherbot gopherbot closed this Aug 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.