Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gerritbot: does not respect codereview.cfg for fixing commit messages #25337

Open
rsc opened this issue May 10, 2018 · 2 comments
Open

Comments

@rsc
Copy link
Contributor

@rsc rsc commented May 10, 2018

https://go-review.googlesource.com/112277, which came from PR golang/vgo#4, said "Fixes #24099." The git-codereview tool would have read the vgo repo's codereview.cfg and automatically rewritten that line to say "Fixes #24099." This helps both authors and reviewers, neither of whom have to think about this anymore. The PR-bot should do the same, because as a reviewer I certainly don't want to lapse back into being in charge of catching this trivial but common mistake. Because the bot did not fix the commit message, the eventual submit did not close the issue.

@rsc rsc added this to the Unreleased milestone May 10, 2018
@andybons andybons changed the title prbot: does not respect codereview.cfg for fixing commit messages x/build/cmd/gerritbot: does not respect codereview.cfg for fixing commit messages May 10, 2018
@gopherbot gopherbot added the Builders label May 10, 2018
@andybons andybons added NeedsFix and removed Builders labels May 10, 2018
@gopherbot gopherbot added the Builders label May 10, 2018
@andybons

This comment has been minimized.

Copy link
Member

@andybons andybons commented Jun 19, 2018

/label help wanted

@agnivade

This comment has been minimized.

Copy link
Contributor

@agnivade agnivade commented Jul 10, 2019

FYI git-codereview has the logic to fix this. This issue is solely about gerritbot. Russ' initial comment is mistaken. git-codereview does indeed do this. But since this is a PR, I am guessing the submitter did not use git-codereview, hence it got missed out.

@andybons andybons removed their assignment Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.