Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/cover: improve html coverage report #25368

Closed
kt3k opened this issue May 13, 2018 · 3 comments
Closed

cmd/cover: improve html coverage report #25368

kt3k opened this issue May 13, 2018 · 3 comments

Comments

@kt3k
Copy link

@kt3k kt3k commented May 13, 2018

This is an issue for discussing the feature suggested in #25267 (111647)

I think the current html coverage report has two problems.

  1. It's hard to navigate through pages.
  2. It's hard to get the overview of the entire coverage.

These are caused by the fact that we use the select box for navigating through pages. I think that is not a standard way to organize the multiple report pages.

My suggestion is that we should have the index page for the html coverage reports. The demo is available at https://kt3k.github.io/go-cover-html-improve-demo/coverage.html

This idea is inspired by the tools like istanbul, JaCoCo or simplecov. They all have the index page of the coverage report.

/cc @ianlancetaylor

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented May 31, 2018

@robpike
Copy link
Contributor

@robpike robpike commented Jun 1, 2018

I think it's fine as is, so you need to ask someone else's opinion to support a change. We don't need visual wonder, we need accurate information in simple form without mounds of Javascript and CSS. The current situation is just fine.

@kt3k
Copy link
Author

@kt3k kt3k commented Jun 1, 2018

OK. This is probably something should be done in a 3rd party tool.

@kt3k kt3k closed this Jun 1, 2018
@golang golang locked and limited conversation to collaborators Jun 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.