testing: test output indentation looks inconsistent when tab width != 4 #25369

Activity

1. dpinela

   changed the title [-]testing: test output indentation looks inconsistent[/-] [+]testing: test output indentation looks inconsistent when tab width != 8[/+] on May 13, 2018
2. dpinela

   changed the title [-]testing: test output indentation looks inconsistent when tab width != 8[/-] [+]testing: test output indentation looks inconsistent when tab width != 4[/+] on May 13, 2018
3. ysmolski commented on May 13, 2018

   

   ysmolski

   on May 13, 2018

   Member

   More actions

   Indeed, there is a mix of tabs and 4 spaces indentations in testing package. I am not sure what was the purpose of tabs in indentation of every line since we have 4 spaces here: https://github.com/golang/go/blob/master/src/testing/testing.go#L429

   A quick fix comes to mind:

   diff --git a/src/testing/testing.go b/src/testing/testing.go
   index 573ef05fdc..ee3bebb7ba 100644
   --- a/src/testing/testing.go
   +++ b/src/testing/testing.go
   @@ -381,7 +381,7 @@ func (c *common) decorate(s string) string {
           }
           buf := new(strings.Builder)
           // Every line is indented at least one tab.
   -       buf.WriteByte('\t')
   +       buf.WriteString("    ")
           fmt.Fprintf(buf, "%s:%d: ", file, line)
           lines := strings.Split(s, "\n")
           if l := len(lines); l > 1 && lines[l-1] == "" {
   

   But it implies fixing tests as well.
4. ysmolski

   added

   NeedsDecisionFeedback is required from experts, contributors, and/or the community before a change can be made.Feedback is required from experts, contributors, and/or the community before a change can be made.

   on May 13, 2018
5. agnivade

   added this to the Go1.11 milestone on May 13, 2018
6. gopherbot commented on May 15, 2018

   

   gopherbot

   on May 15, 2018

   Contributor

   More actions

   Change https://golang.org/cl/113177 mentions this issue: testing: make indentation consistent in sub-tests
7. ysmolski

   added

   NeedsFixThe path to resolution is known, but the work has not been done.The path to resolution is known, but the work has not been done.

   and removed

   NeedsDecisionFeedback is required from experts, contributors, and/or the community before a change can be made.Feedback is required from experts, contributors, and/or the community before a change can be made.

   on May 15, 2018
8. ysmolski commented on May 15, 2018

   

   ysmolski

   on May 15, 2018

   Last edited by ysmolski

   Member

   More actions

   I wonder if this change can break others programs or some Golang promises.
   ping @andybons @bradfitz
9. ysmolski

   modified the milestones: Go1.11, Go1.12 on May 29, 2018
10. gopherbot

    closed this as completedin fffb3a5on May 31, 2018
11. andybons commented on Jun 1, 2018

    

    andybons

    on Jun 1, 2018

    Last edited by andybons

    Member

    More actions

    I think it’s fine. If someone is relying on the textual output of tests instead of using the JSON output, then this will be a good reason for them to switch :)
12. golang

    locked and limited conversation to collaborators on Jun 1, 2019
13. gopherbot

    added

    FrozenDueToAge

    on Jun 1, 2019