Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vgo: vgo vendor must process all tags #25376

Closed
wzshiming opened this issue May 14, 2018 · 2 comments

Comments

@wzshiming
Copy link

commented May 14, 2018

What version of Go are you using (go version)?

go version go1.10.1 darwin/amd64 vgo:2018-02-20.1

Does this issue reproduce with the latest release?

no

What did you expect to see?

In MAC, Linux depends on the package vendor.

@gopherbot gopherbot added this to the vgo milestone May 14, 2018

@wzshiming wzshiming changed the title x/vgo `vgo vendor` Should ignore tags x/vgo: `vgo vendor` Should ignore tags May 14, 2018

@rsc rsc changed the title x/vgo: `vgo vendor` Should ignore tags x/vgo: vgo vendor must process all code Jun 6, 2018

@rsc rsc changed the title x/vgo: vgo vendor must process all code x/vgo: vgo vendor must process all tags Jun 6, 2018

@rsc

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2018

The problem here is that if you have a source file x.go that says // +build linux and you are on a Mac, then the default loader will ignore it. An import specific to that file will not be seen and not be explored for vendoring purposes. It needs to be.

@gopherbot

This comment has been minimized.

Copy link

commented Jun 7, 2018

Change https://golang.org/cl/117258 mentions this issue: cmd/go/internal/vgo: process packages for all build tags in vendor

@golang golang locked and limited conversation to collaborators Jun 12, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.