Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/ssh: revive tests, run by default on trybots #25386

Open
bradfitz opened this Issue May 14, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@bradfitz
Copy link
Member

bradfitz commented May 14, 2018

The x/crypto/ssh integration tests with OpenSSH's sshd in x/crypto/ssh/test don't run by default, and don't seem to work on Debian Jessie nor Debian Stretch.

It's not clear when they last worked or in which environment.

This is a tracking bug to revive them and make them run on the builders.

/cc @hanwen

@bradfitz bradfitz self-assigned this May 14, 2018

@gopherbot gopherbot added this to the Unreleased milestone May 14, 2018

@bradfitz bradfitz added the Testing label May 14, 2018

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented May 14, 2018

Change https://golang.org/cl/113059 mentions this issue: dashboard, env: add Debian Stretch builder, rename Jessie builder

@bradfitz

This comment has been minimized.

Copy link
Member Author

bradfitz commented May 14, 2018

This will need a Debian Stretch builder, as Debian Jessie (our current builders) have OpenSSH 6.6 and it wasn't until OpenSSH 6.7 that forwarding Unix sockets was supported, which the x/crypto/ssh tests try to exercise. Also, OpenSSH 6.6 doesn't recognize the sshd_config option PubkeyAcceptedKeyTypes.

gopherbot pushed a commit to golang/build that referenced this issue May 14, 2018

dashboard, env: add Debian Stretch builder, rename Jessie builder
Updates golang/go#25386

Change-Id: I65e3dda63e5ea86fa94480e3305556b73afe121a
Reviewed-on: https://go-review.googlesource.com/113059
Reviewed-by: Bryan C. Mills <bcmills@google.com>

@bradfitz bradfitz added the help wanted label Nov 1, 2018

@bradfitz bradfitz removed their assignment Nov 1, 2018

@bradfitz bradfitz added the Builders label Nov 1, 2018

@bradfitz

This comment has been minimized.

Copy link
Member Author

bradfitz commented Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.