Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
x/crypto/ssh: revive tests, run by default on trybots #25386
It's not clear when they last worked or in which environment.
This is a tracking bug to revive them and make them run on the builders.
This will need a Debian Stretch builder, as Debian Jessie (our current builders) have OpenSSH 6.6 and it wasn't until OpenSSH 6.7 that forwarding Unix sockets was supported, which the x/crypto/ssh tests try to exercise. Also, OpenSSH 6.6 doesn't recognize the
While debugging golang/go#25386 I found that the firewall defaulting to on made debugging modules hard. So make gomote default to no outbound firewall and make it opt-in for people who want to reproduce the builder more. Also in this CL: start to use server's builder config, not local state (follow up to CL 169678 which was incomplete). It's still incomplete in this CL, but there's now a panic with more useful information to users telling them to update their binary. Updates golang/go#30929 Change-Id: I17bded71919af1e7a9181866a1349eb72da40051 Reviewed-on: https://go-review.googlesource.com/c/build/+/170397 Reviewed-by: Dmitri Shuralyov <email@example.com>