Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/sha3: add cSHAKE support #25395

Closed
henrydcase opened this issue May 15, 2018 · 5 comments
Closed

x/crypto/sha3: add cSHAKE support #25395

henrydcase opened this issue May 15, 2018 · 5 comments

Comments

@henrydcase
Copy link

@henrydcase henrydcase commented May 15, 2018

The code for cSHAKE is now ready here https://go-review.googlesource.com/c/crypto/+/111281/

Is there any chance to merge it soon?

@FiloSottile FiloSottile changed the title sha3: add cSHAKE support x/crypto/sha3: add cSHAKE support May 15, 2018
@gopherbot gopherbot added this to the Unreleased milestone May 15, 2018
@FiloSottile
Copy link
Member

@FiloSottile FiloSottile commented May 15, 2018

(This was approved in #24988.)

This week is the Go team summit so we are going to be a bit slow at reviewing, sorry about that.

@henrydcase
Copy link
Author

@henrydcase henrydcase commented May 15, 2018

Ok, thnx for update. No worries, have fun.

@odeke-em
Copy link
Member

@odeke-em odeke-em commented May 17, 2018

I'll also page @veorq, if you get bored or have some free time, please feel free to take a look at the CL above posted :)

@henrydcase
Copy link
Author

@henrydcase henrydcase commented Jul 26, 2018

Hi, is there something I can do, so that it can get merged?

@henrydcase
Copy link
Author

@henrydcase henrydcase commented Apr 17, 2019

@henrydcase henrydcase closed this Apr 17, 2019
FiloSottile added a commit to FiloSottile/go that referenced this issue Nov 24, 2019
This patch implements 128- and 256-bit version of customizable variant
of SHAKE function (cSHAKE).

* Implementation based on NIST FIPS 202
* Test data file has been updated with cSHAKE KATs. I've copied
  examples from NIST document available here:
  https://csrc.nist.gov/csrc/media/projects/cryptographic-standards-and
  -guidelines/documents/examples/cshake_samples.pdf

Fixes golang#25395

Change-Id: Icbbc4232f3d9a28b3d6ead51937c2e60c00e5d8c
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/111281
Reviewed-by: Filippo Valsorda <filippo@golang.org>
@golang golang locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.