New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/gofmt: better error message when gofmt is out of date #25430

Open
griesemer opened this Issue May 16, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@griesemer
Contributor

griesemer commented May 16, 2018

It's not uncommon to run an old gofmt that may not be up-to-date with the latest syntactic changes (most recently, alias type declarations). There may be future (Go 2) changes where this becomes more acute.

When gofmt reports a syntax error, we may want to compare the gofmt (build time) version with the current "go version" and possibly report significant version discrepancies with the error ("please update gofmt").

Reminder issue to look into this.

@griesemer griesemer added this to the Go1.11 milestone May 16, 2018

@griesemer griesemer self-assigned this May 16, 2018

@randall77

This comment has been minimized.

Contributor

randall77 commented May 16, 2018

Also goimports.

@griesemer

This comment has been minimized.

Contributor

griesemer commented Jun 12, 2018

@randall77 Added separate issue #25856.

@ianlancetaylor ianlancetaylor modified the milestones: Go1.11, Go1.12 Jun 23, 2018

@griesemer

This comment has been minimized.

Contributor

griesemer commented Jun 27, 2018

The issue for importers has been addressed (#25856). We're probably not going to make major syntactic changes towards Go 2 in 1.12, so postponing for next release.

@harshavardhana harshavardhana referenced this issue Jul 24, 2018

Merged

Fix make test failure #6185

3 of 9 tasks complete

@ianlancetaylor ianlancetaylor modified the milestones: Go1.12, Go1.13 Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment