Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/devapp: show GitHub usernames for CLs from PRs #25447

Open
bradfitz opened this issue May 17, 2018 · 1 comment
Open

x/build/devapp: show GitHub usernames for CLs from PRs #25447

bradfitz opened this issue May 17, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@bradfitz
Copy link
Member

@bradfitz bradfitz commented May 17, 2018

Gerritbot brings in PRs to Gerrit with the author "Gerrit Bot", and this makes its way to the dev dashboard:

https://dev.golang.org/reviews?owner=Gerrit%20Bot

We should show GitHub usernames there instead.

/cc @andybons @bcmills @FiloSottile

@dmitshur

This comment has been minimized.

Copy link
Member

@dmitshur dmitshur commented Aug 4, 2018

We also have issue #23964, which is the root problem. When/if that is resolved, this issue will be obsolete.

If that issue is lot of work and takes a long while, while this one is quick and easy, it might be worth it to solve it with a // TODO: Remove when golang.org/issue/23964 is resolved. comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.