x/mobile: copy comments to generated headers #25473
Closed
Labels
Milestone
Comments
CC: @eliasnaur |
Change https://golang.org/cl/114056 mentions this issue: |
Change https://golang.org/cl/114055 mentions this issue: |
gopherbot
pushed a commit
to golang/mobile
that referenced
this issue
May 22, 2018
Updates golang/go#25473 Change-Id: I63bf8dde15b0f108eabdc653b59039607b47a0aa Reviewed-on: https://go-review.googlesource.com/114055 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
MarkVillacampa
added a commit
to MarkVillacampa/mobile
that referenced
this issue
Jun 26, 2018
Updates golang/go#25473 Change-Id: I63bf8dde15b0f108eabdc653b59039607b47a0aa Reviewed-on: https://go-review.googlesource.com/114055 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
MarkVillacampa
added a commit
to MarkVillacampa/mobile
that referenced
this issue
Jun 26, 2018
CL 99316 moved generation of bindings from the the gomobile command to the gobind command. In the process, the ability to copy over documentation from the Go source to the derived Java and ObjC was lost. The relevant test didn't fail because it tests the generator itself, not gobind. Re-add support and add a gobind test for it. Fixes golang/go#25473 Change-Id: I6eee3e79173f37d3e3e65eabc0bad59e4252da64 Reviewed-on: https://go-review.googlesource.com/114056 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
use golang build mobile library for other developers,mybe include comments better
source code
command:
gomobile bind -v -target=ios ...
output framework header
want include comments
The text was updated successfully, but these errors were encountered: