Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: vgo version shows incorrect version #25514

Closed
komuw opened this issue May 23, 2018 · 3 comments

Comments

Projects
None yet
5 participants
@komuw
Copy link
Contributor

commented May 23, 2018

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.10 linux/amd64

Does this issue reproduce with the latest release?

N/A

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="~/go"
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build427797830=/tmp/go-build -gno-record-gcc-switches"

What did you do?

go get -u golang.org/x/vgo && \
vgo version

If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.

What did you expect to see?

I expected to see an updated vgo version

What did you see instead?

go version go1.10 linux/amd64 vgo:2018-02-20.1

the version displayed is the one hard coded at; https://github.com/golang/vgo/blob/b39cea3cb5353f4fc7f08919d32a0006ea3ed62a/vendor/cmd/go/internal/version/version.go#L16

@komuw komuw changed the title vgo version shows incorrect version x/vgo: vgo version shows incorrect version May 23, 2018

@gopherbot gopherbot added this to the vgo milestone May 23, 2018

@agnivade

This comment has been minimized.

Copy link
Member

commented May 31, 2018

I am not sure whether this should be considered as a bug. Most probably, it was supposed to be a debug string to differentiate between go and vgo commands. It will anyways go away once vgo is integrated within go.

/cc @rsc , @kardianos

@myitcv

This comment has been minimized.

Copy link
Member

commented May 31, 2018

Just for the record (not an opinion on whether this should be fixed or not), the canonical way we have been gathering more specific information to help debug issues in the #vgo Slack channel is via:

(command cd $(go list -f "{{.Dir}}" golang.org/x/vgo); git rev-parse HEAD)
@gopherbot

This comment has been minimized.

Copy link

commented Jul 12, 2018

Change https://golang.org/cl/123579 mentions this issue: cmd/go: import from main repo

@rsc rsc modified the milestones: vgo, Go1.11 Jul 12, 2018

@rsc rsc added the modules label Jul 12, 2018

@rsc rsc changed the title x/vgo: vgo version shows incorrect version cmd/go: vgo version shows incorrect version Jul 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.