Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/buildutil: make ExpandPatterns support all go tool patterns #25543

Open
rogpeppe opened this issue May 24, 2018 · 1 comment
Open
Labels
Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@rogpeppe
Copy link
Contributor

This TODO exists within the ExpandPatterns function:

// TODO(adonovan): support other features of 'go list':
// - "std"/"cmd"/"all" meta-packages
// - "..." not at the end of a pattern
// - relative patterns using "./" or "../" prefix

I'd very much like to use golang.org/x/tools/go/buildutil instead of github.com/kisielk/gotool but the current limitations mean that I can't do so without breaking backward compatibility.

@gopherbot gopherbot added this to the Unreleased milestone May 24, 2018
@mewmew
Copy link
Contributor

mewmew commented Oct 6, 2018

I am also struck by this issue, mainly as buildutil.ExpandPatterns does not yet support relative paths.

cc: @adonovan would it be possible to either copy the functionality used by the Go tool to the implementation of buildutil.ExpandPatterns or to expose the functionality of the Go tool for locating import paths based on patterns?

mewmew added a commit to mewspring/lbg that referenced this issue Oct 7, 2018
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants