Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/compile: unexpected error about conflicting package heights #25568
While trying to remove use of perl from test/fixedbugs/bug345.go, I have encountered following behaviour about conflicting package heights.
I am not sure if it's a bug or expected feature.
What version of Go are you using (
@neild thanks for pointing to that. adding "-iexport=false" affects the problem but does not "fixes" it at all. Since the rest of stdlib was compiled with -iexport=true, the tested package cannot be compiled. I am a little lost here now. Not sure if that is a bug that should be fixed..
referenced this issue
May 26, 2018
Yes, if I run the same sequence of commands with the commit prior CL 106797 I see the desired output from the compiler:
I have verified that bisecting leads to CL 106797 as a bad commit
@ysmolsky I can reproduce it but as is this is not a bug after all: You are providing additional compiler flags (-D, -I) and they are set relative to the current (test) directory. For one, it doesn't appear that those paths can be relative (at least it doesn't work for me) though that is unrelated: In your command line you're not providing the correct path for -D. Furthermore, you don't need -I here. (You also don't need -D if you do everything in bug345.dir).
That is, what happens is that you don't get the correct "io" packages here.
I get correct behavior if I choose one of two options:
A) Do everything in the local directory:
B) Do everything in the go/test directory, without or with correct -D argument:
Or provide a -D as in:
Thus I think this is working as intended. (Feel free to re-open if you disagree.)