-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Open
Labels
NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.Performance
Milestone
Description
For multiplication and squaring we use different algorithms depending on the input length. We currently have 3 threshold constants to decide which algorithm to use. These are calibrated with TestCalibrate.
This calibration takes multiple minutes to run and the outcome doesn't seem to be that reliable. Last noticed in cl 105075.
Quote @griesemer :
On my machine, the threshold is much lower (less than 200). At some point we need to find a better way to determine these values.
I see three issues:
- Reliable result on a single machine: this worked on my machine, but didn't for @ALTree.
- Similar results on different machines: for calibrating
karatsubaSqrThresholdwe got differences of more than 100% between our 3 machines - Slowness. This might be less important, but if this wouldn't take multiple minutes where you shouldn't run other programs it might be easier to ask more people to run the calibration.
Metadata
Metadata
Assignees
Labels
NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.Performance