Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/cgo: "DO NOT EDIT" generated code comments do not follow recommendations #25623

Closed
bontibon opened this issue May 29, 2018 · 1 comment

Comments

@bontibon
Copy link
Contributor

commented May 29, 2018

cgo currently generates files with header comments in the following forms:

  • /* Created by "go tool cgo" - DO NOT EDIT. */, and
  • // Created by cgo - DO NOT EDIT

These do not following the recommendations made in #13560 (https://golang.org/s/generatedcode).

@bontibon bontibon changed the title cgo: "DO NOT EDIT" generated code comment does not follow recommendations cgo: "DO NOT EDIT" generated code comments do not follow recommendations May 29, 2018

@ianlancetaylor ianlancetaylor changed the title cgo: "DO NOT EDIT" generated code comments do not follow recommendations cmd/cgo: "DO NOT EDIT" generated code comments do not follow recommendations May 29, 2018

@ianlancetaylor ianlancetaylor added this to the Go1.11 milestone May 29, 2018

@gopherbot

This comment has been minimized.

Copy link

commented May 29, 2018

Change https://golang.org/cl/115035 mentions this issue: cmd/cgo: use standard generated code comment

@gopherbot gopherbot closed this in ab922e1 May 29, 2018

@golang golang locked and limited conversation to collaborators May 29, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.