Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vgo: unknown module git.apache.org/thrift.git/lib/go/thrift: no go-import tags #25654

Closed
sami9gag opened this issue May 31, 2018 · 2 comments
Closed

Comments

@sami9gag
Copy link

@sami9gag sami9gag commented May 31, 2018

What version of Go are you using (go version)?

go version go1.10.2 darwin/amd64 vgo:2018-02-20.1

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

GOHOSTARCH="amd64"
GOHOSTOS="darwin"

What did you do?

I'm trying to pull dependencies for a project using opencensus, which depends on thrift. The thrift dependency fails to pull due to missing import tags. This can be reproduced with the following snippet:

package main

import (
	"go.opencensus.io/exporter/jaeger"
)

func main() {
	_ = jaeger.Options{}
}

When using vgo get -u on that snippet, the pull will fail with an error: unknown module git.apache.org/thrift.git/lib/go/thrift: no go-import tags

The failure appears to be caused by this line in one of the dependencies:
https://github.com/census-instrumentation/opencensus-go/blob/master/exporter/jaeger/jaeger.go#L28

This works with go get -u

What did you expect to see?

I expected vgo get -u to complete normally after pulling the dependencies.

What did you see instead?

[...]
vgo: resolving import "git.apache.org/thrift.git/lib/go/thrift"
vgo: import "github.com/sami9gag/vgo-break" ->
        import "go.opencensus.io/exporter/jaeger" ->
        import "git.apache.org/thrift.git/lib/go/thrift": unknown module git.apache.org/thrift.git/lib/go/thrift: no go-import tags
@gopherbot gopherbot added this to the vgo milestone May 31, 2018
@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Jun 6, 2018

The problem is that vgo does not understand the .git name convention.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jun 20, 2018

Change https://golang.org/cl/120042 mentions this issue: cmd/go/internal/modfetch: fix Lookup, Import; add ImportRepoRev

@golang golang locked and limited conversation to collaborators Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.