x/sys/windows: return more information from Query

[pytimer]

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.10 windows/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

set GOARCH=amd64
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOROOT=C:\Go
set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64

What did you do?

I want to use sys/windows/svc/mgr Query() get the specifed service info

What did you expect to see?

I hope it can return more additional info, such as Win32ExitCode, ServiceType. It is best to return service PID.

What did you see instead?

Now this function only return State and Accepts.

service PID should call QueryServiceStatusEx, but now Query() call QueryServiceStatus, i see windows api doc says QueryServiceStatus has been superseded by the QueryServiceStatusEx function.

So whether use QueryServiceStatusEx replace QueryServiceStatus in Query()?

[ianlancetaylor]

CC @alexbrainman

[alexbrainman]

@pytimer

I take it you want to add more fields to golang.org/x/sys/windows/svc.Status structure. Am I correct?

If so, you have to tell more. You have to explain what fields you want to add and why.

Thank you.

Alex

[pytimer]

Hi, @alexbrainman

Thanks for your reply. You are right, i want to add some fields to svc.Status.

Win32ExitCode i want to get the service exit code, then my program can do something according to it.

ServiceType, it tell me what type of the service.

ProcessId we can get service pid and then monitor this process. we also can get process information.

Have i explained clearly?If not, you tell me.

[alexbrainman]

i want to add some fields to svc.Status.

svc.Status is populated from SERVICE_STATUS structure. For ProcessId we have to use SERVICE_STATUS_PROCESS instead. And service code in golang.org/x/sys/windows/svc uses SetServiceStatus to update service status. There is no SetServiceStatus alternative that takes SERVICE_STATUS_PROCESS instead of SERVICE_STATUS, so we cannot use SERVICE_STATUS_PROCESS in golang.org/x/sys/windows/svc .

The only way for you to get ProcessId is for us to change golang.org/x/sys/windows/svc/mgr.Query to return something different from svc.Status - perhaps create new Status struct in golang.org/x/sys/windows/svc/mgr with whatever fields required. If we do that, we would have to do the same to golang.org/x/sys/windows/svc/mgr.Control. This will brake existing programs, so we should not take this decisions lightly.

Alternatively you could just use golang.org/x/sys/windows/svc/mgr.Service.Handle and call whatever Windows function you want to get what you want.

What do you think?

Alex

[pytimer]

Thanks for your reply.

I understand what you mean, you are right.

If i want to more information, i will use golang.org/x/sys/windows/svc/mgr.Service.Handle and call Windows function.

Thanks again. :)

[alexbrainman]

Thanks again. :)

No worries. I will close this issue. Please reopen, if there is something else to do here.

Alex

[pytimer]

OK! :)