Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: GODEBUG=gocacheverify=1 ./all.bash fails on tip #25666

Closed
martisch opened this issue May 31, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@martisch
Copy link
Member

commented May 31, 2018

What version of Go are you using (go version)?

go tip

../bin/go version
go version devel +caf968616a Thu May 31 13:29:50 2018 +0000 linux/amd64

What did you do?

go clean -cache
GODEBUG=gocacheverify=1 ./all.bash

What did you expect to see?

no panic

What did you see instead?

ok regexp/syntax 0.432s
panic: go: internal cache error: cache verify failed: id=7d1de7e02583755526739389bd6fc1974cfc37da58553b099fd623bd77a6f437 changed:<<<
compile
goos linux goarch amd64
import "cmd/cover"
omitdebug false standard true local false prefix ""
compile Z5KkeuwGD_YmlK9AKqhE [] []
GO$GOARCH=
file cover.go -HJGpdKieEMMOCO-mPxL
file doc.go q8cjgpxRyr-B4c0-BSxm
file func.go XsiVkomYxidS7PwWXQ2n
file html.go 4Y1BIbPC6AVLRyO7P_1x
file profile.go 0v22dDl9QjcWlQUwc8ke
import bufio x_-ZmcJaRE1-62HC7gEy
import bytes -ExnlBGGJxi4VZ5EqPw6
import cmd/internal/browser -OSlaIN89ju-lKeJTEtZ
import cmd/internal/edit eAcymmmTWYX7N48foFvc
import cmd/internal/objabi Wx6XuWtw8yzI2OUM-I1X
import flag Apc7KW-rM8Do39ESNy9L
import fmt IKr8q_ka3BkoAGXRW9vb
import go/ast 3lMn5Fnsr6X1r8KaWvmX
import go/build WEmUKvioE4gojuLKr7yC
import go/parser zgKhNbLoAKQRyd-wKYnd
import go/token pjlHSTQZQ8NEhm62LFhU
import html/template IZspSCnOsTK022SyxgwV
import io JUl0LPhkSJ8CDbdJmbME
import io/ioutil T5jUc1oEVPHnwKrVw-ew
import log qVNeFQ1akGgeIZX9TSVx
import math xYExcA8201vQyyZ9IGvw
import os 2N6oAGLW3b6OMDDak_Kv
import path/filepath Zw1gJYZoXyx4xrS4j8bU
import regexp t9sroldeoNMIbrsNDHls
import sort sPmY1SAx3P0TLUoaIIy8
import strconv QtFWYl284THTUEfpinB4
import strings 23Tj_-1ryGCvgpeL4R6K
import text/tabwriter qUQ4bN_UZwnU03hZEjys
import runtime v2qTneM1d0huhg0jpHvU

old: c802e90778868f599f331dc9c7967c87ff18c2e087b473ab9a126a5be6f1b242 217716
new: 300d198f10396404918e48056311287053936e1ef01988ff065235f01f0405ae 217700

@martisch martisch added this to the Go1.11 milestone May 31, 2018

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented May 31, 2018

Do you know which test is failing? I can't tell from the output.

@martisch

This comment has been minimized.

Copy link
Member Author

commented May 31, 2018

GODEBUG=gocacheverify=1 go test cmd/cover

is a shorter reproduction of the above error. Found after a guess from the import "cmd/cover" statement in the output.

@gopherbot

This comment has been minimized.

Copy link

commented Jul 2, 2018

Change https://golang.org/cl/121941 mentions this issue: cmd/vet: make vetx output deterministic

@gopherbot

This comment has been minimized.

Copy link

commented Jul 2, 2018

Change https://golang.org/cl/121942 mentions this issue: cmd/go: add ForceLibrary to build hash

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2018

I found two problems and sent two CLs.

gopherbot pushed a commit that referenced this issue Jul 3, 2018

cmd/vet: make vetx output deterministic
The vetx output file is a build output, and as such should be
deterministic. This CL changes it to not depend on map iteration order.

This avoids a pointless GODEBUG=gocacheverify=1 failure.

Updates #25666

Change-Id: Ic132bad134cb10938275f883c2c68432cb7c4409
Reviewed-on: https://go-review.googlesource.com/121941
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rob Pike <r@golang.org>

@gopherbot gopherbot closed this in 9a97a2a Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.