Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: two implementations of hasprefix #25688

Closed
bontibon opened this issue Jun 1, 2018 · 1 comment
Closed

runtime: two implementations of hasprefix #25688

bontibon opened this issue Jun 1, 2018 · 1 comment
Assignees
@martisch
Labels
FrozenDueToAge
Milestone
Go1.12

Comments

@bontibon
Copy link
Contributor

@bontibon bontibon commented Jun 1, 2018 •
edited

runtime defines hasprefix(string, string) bool in string.go and hasPrefix(string, string) bool in type.go. They have identical implementations.

I do not know how they are used, but I imagine that either (a) one should be removed in favour of the other, or (b) document why both need to exist.
@martisch martisch self-assigned this Jun 1, 2018
@martisch martisch added this to the Go1.12 milestone Jun 1, 2018
@martisch martisch added NeedsFix and removed NeedsFix labels Jun 1, 2018
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

@gopherbot gopherbot commented Jun 1, 2018

Change https://golang.org/cl/115835 mentions this issue: runtime: replace calls to hasprefix with hasPrefix
@gopherbot gopherbot closed this in b0dc546 Aug 22, 2018
@golang golang locked and limited conversation to collaborators Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@martisch martisch

Labels
FrozenDueToAge
Projects
None yet
Milestone
  Go1.12
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@bontibon @gopherbot @martisch
You can’t perform that action at this time.