Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: two implementations of hasprefix #25688

Closed
bontibon opened this issue Jun 1, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@bontibon
Copy link
Contributor

commented Jun 1, 2018

runtime defines hasprefix(string, string) bool in string.go and hasPrefix(string, string) bool in type.go. They have identical implementations.

I do not know how they are used, but I imagine that either (a) one should be removed in favour of the other, or (b) document why both need to exist.

@martisch martisch self-assigned this Jun 1, 2018

@martisch martisch added this to the Go1.12 milestone Jun 1, 2018

@martisch martisch added NeedsFix and removed NeedsFix labels Jun 1, 2018

@gopherbot

This comment has been minimized.

Copy link

commented Jun 1, 2018

Change https://golang.org/cl/115835 mentions this issue: runtime: replace calls to hasprefix with hasPrefix

@gopherbot gopherbot closed this in b0dc546 Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.