Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
x/vgo: modconv doesn't retain "replace" directive information on conversion to go.mod #25692
go version go1.10 linux/amd64 vgo:2018-02-20.1
this is against the latest Prometheus master.
it seems some awkward case with "origin" and "path"
changed the title
x/vgo: doesn't parse "origin", "path" properly from govendor vendor.json
Jun 2, 2018
What is origin? It looks like when a well-known repository path on disk is overwritten by a fork but keeps the well known path in the import declarations.
I have encountered this practice a few times and it is very confusing for people to decipher what is going on. It reminds me of the chaos caused by symbolic links sometimes.
as per my original description this is the master branch of the Prometheus repo so it is the govendor file from there
In vgo package modconv, the vjson.go file is missing support for reading the Origin field present in govendor vendor/vendor.json files. This should translate to a replace directive in the go.mod file.
This is issue is a request to maintain that information when converting the vendor.json file to go.mod file.