Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/compile: cannot import "./package" on Windows #25693
Test cannot import dotted package which was compiled in local directory.
Reproduce in Windows:
Specifically it can be reproduced by following sequence:
I do not have an access to dev env in Windows so I cannot investigate any further.
@bradfitz Should I disable the test for Windows until the fix is found or should I revert the original CL completely?
We probably shouldn't have done cleanups like this during the freeze. Maybe @ianlancetaylor and I just really want to see this dependency gone.
How about we revert on Tuesday (US/Pacific) if it's not fixed before then?
Before the CL in question (https://golang.org/cl/115277) we did not run the test on Windows, so let's just go back to not running the test on Windows. The test is failing for reasons that are unrelated to the point of the test. There is nothing OS-specific about this test, so skipping it on Windows doesn't seem like a big deal.
Before the CL 115277 we did not run the test on Windows, so let's just go back to not running the test on Windows. There is nothing OS-specific about this test, so skipping it on Windows doesn't seem like a big deal. Updates #25693 Fixes #25586 Change-Id: I1eb3e158b322d73e271ef388f8c6e2f2af0a0729 Reviewed-on: https://go-review.googlesource.com/115857 Run-TryBot: Yury Smolsky <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org> Reviewed-by: Ian Lance Taylor <email@example.com>
Sorry, I forgotten about this issue.
If I make this change
diff --git a/test/fixedbugs/bug345.go b/test/fixedbugs/bug345.go index b974a61ffb..04c28ce857 100644 --- a/test/fixedbugs/bug345.go +++ b/test/fixedbugs/bug345.go @@ -1,4 +1,3 @@ -// +build !windows // errorcheckdir -n // Copyright 2011 The Go Authors. All rights reserved. @@ -6,5 +5,3 @@ // license that can be found in the LICENSE file. package ignored - -// TODO(ysmolsky): Fix golang.org/issue/25693 to enable on Windows.
to f70bd91 and run this command
I can see the error.
But I am not familiar enough with how compiler works. The source file does not have any imports containing
So compiler must be replacing
Is that valid? If it is valid thing to do, then compiler should be able to handle Windows paths like
While investigating another . related issue on Windows, it appeared that this test is now successful.