Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestLookupHostCancel and TestCloseRead flaky on Yosemite #25694

Closed
bcmills opened this issue Jun 1, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@bcmills
Copy link
Member

commented Jun 1, 2018

Examples:
https://build.golang.org/log/63ea433daf839bebe655c49e196c359e83586e88
https://build.golang.org/log/460d2123fc01822ebd2bb6a224e2dedaaaebbaa7
https://build.golang.org/log/49bc59d02f5575c538997f59602d727617c3723e

All with this failure mode:

--- FAIL: TestLookupHostCancel (0.80s)
    lookup_test.go:923: lookup www.google.com: no such host
--- FAIL: TestCloseRead (0.00s)
panic: open /var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/go-nettest731919775: too many open files [recovered]
	panic: open /var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/go-nettest731919775: too many open files

goroutine 2188 [running]:
testing.tRunner.func1(0xc0000b6200)
	/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/src/testing/testing.go:792 +0x387
panic(0x124af40, 0xc00066b2c0)
	/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/src/runtime/panic.go:494 +0x1b9
net.testUnixAddr(0x1285969, 0x4)
	/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/src/net/mockserver_test.go:23 +0xc3
net.newLocalListener(0x1285969, 0x4, 0x1, 0x1, 0x0, 0x12ca1e0)
	/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/src/net/mockserver_test.go:51 +0x2d5
net.TestCloseRead(0xc0000b6200)
	/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/src/net/net_test.go:30 +0xcf
testing.tRunner(0xc0000b6200, 0x1296b78)
	/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/src/testing/testing.go:827 +0xbf
created by testing.(*T).Run
	/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/src/testing/testing.go:878 +0x353
FAIL	net	2.369s

@bcmills bcmills changed the title net: TestLookupHostCancel and TestCloseRead flaky on D net: TestLookupHostCancel and TestCloseRead flaky on Yosemite Jun 1, 2018

@bcmills bcmills added this to the Go1.11 milestone Jun 1, 2018

@bcmills

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2018

@bradfitz

This comment has been minimized.

Copy link
Member

commented Jun 5, 2018

I think these are all just ulimit issues. I recall from a previous bug that "no such host" is a red herring... it's really just some socket creation error in the DNS lookup process.

I suspect the net package has grown parallel enough that we're up against the Mac's low limits.

We should probably have the buildlet crank up the limit on start-up.

@gopherbot

This comment has been minimized.

Copy link

commented Jun 27, 2018

Change https://golang.org/cl/121176 mentions this issue: net: limit concurrent threads to limit on file descriptors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.