Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/json: unsupported value: NaN #25721

Closed
XANi opened this issue Jun 4, 2018 · 4 comments
Closed

encoding/json: unsupported value: NaN #25721

XANi opened this issue Jun 4, 2018 · 4 comments

Comments

@XANi
Copy link

@XANi XANi commented Jun 4, 2018

Bot closed the previous issue ( #3480 ), just reminding problem still exists

What version of Go are you using (go version)?

go version go1.9.2 linux/amd64

Does this issue reproduce with the latest release?

It does with go playground

What did you do?

Same as #3480

https://play.golang.org/p/K4xwS7iy4MP

What did you expect to see?

Not throwing serialization errors on basic numeric data types with valid state

What did you see instead?

json: unsupported value: NaN

Which is by the way very uninformative and badly written error message as it doesn't show which key showed that error which just makes hunting the source of NaN utter pain in arse

@mvdan

This comment has been minimized.

Copy link
Member

@mvdan mvdan commented Jun 4, 2018

This has come up in the past; have you read this thread? #3480

Also, if you'd like the error to be better, I'd file a separate issue. There have been similar ones in the past, such as #6716 and #11858.

@XANi

This comment has been minimized.

Copy link
Author

@XANi XANi commented Jun 4, 2018

@mvdan yes I did, and I'm aware that it is pretty messy issue, but IMO just having to deal with NaN being either NaN, inf+ or inf- is better than having ser/des of one document fail because of single (and, currently, hard to find) NaN.

From my experience with other libs in other languages most of them just chose to break strict adherence to JSON buggy mess standard in favour of preserving inf/nan via string representation.

And currently Go is also breaking the standard, just in other way, err'ing out when it should just return string "null", and err'ing out on ingestion with no option to opt out.

Maybe adding additional struct options would help? Like:

  • nan_as_null - treat string "null" as nan; serialize NaN to "null", err out on inf+/inf-
  • nan_as_string - treat string "nan" (and case variations) as nan; serialize NaN to "nan", err out on inf+/inf-
  • inf_as_string - stringify/accept string inf/-inf; with option above woud generate/decode -inf/nan/inf
  • ecma_null - do as standard stays on encoding, decode null to nan and let user worry what to do about it
@FiloSottile

This comment has been minimized.

Copy link
Member

@FiloSottile FiloSottile commented Jun 5, 2018

Closing this as a duplicate of #3480. You can open a proposal for your suggested change, or you can file a separate issue for improving the error message.

@FiloSottile FiloSottile closed this Jun 5, 2018
@AndrewWPhillips

This comment has been minimized.

Copy link

@AndrewWPhillips AndrewWPhillips commented Jan 31, 2019

Just create your own custom decoder (and encoder too if nec.)

@golang golang locked and limited conversation to collaborators Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.