Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vgo: tests unexpectedly prompt for GitHub username and password #25742

Closed
bcmills opened this issue Jun 5, 2018 · 10 comments

Comments

@bcmills
Copy link
Member

commented Jun 5, 2018

When I try to run the tests for vgo, I get username and password prompts.

If this is a configuration issue with my tools or environment, the tests should instead fail with a helpful error message so that I can run some command that more obviously indicates what it intends to do with the credentials.

Otherwise, the tests should not prompt for credentials at all.

~/src/golang.org/x/vgo/vendor/cmd/go$ git pull
Already up to date.
~/src/golang.org/x/vgo/vendor/cmd/go$ git checkout master
Already on 'master'
Your branch is up to date with 'origin/master'.
~/src/golang.org/x/vgo/vendor/cmd/go$ go version
go version devel +6b4828a206 Thu May 31 15:24:46 2018 +0000 linux/amd64
~/src/golang.org/x/vgo/vendor/cmd/go$ go test ./...
Username for 'https://github.com': Username for 'https://github.com':

@gopherbot gopherbot added this to the vgo milestone Jun 5, 2018

@bcmills

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2018

~/src/golang.org/x/vgo/vendor/cmd/go$ go test ./...
Username for 'https://github.com': Username for 'https://github.com': --- FAIL: TestExecutableGOROOT (0.15s)
    --- FAIL: TestExecutableGOROOT/RuntimeGoroot (0.00s)
        go_test.go:4598: /tmp/gotest707094873/new/bin/go run testdata/print_goroot.go: exit status 1, vgo requires Go 1.10 but VGOROOT=/tmp/gotest707094873/new is not a Go 1.10 source tree
--- FAIL: TestTestRegexps (0.39s)
        go_test.go:4743: running testgo [test -cpu=1 -run=X/Y -bench=X/Y -count=2 -v testregexp]
        go_test.go:4743: standard output:
        go_test.go:4743: === RUN   TestX
                === RUN   TestX/Y
                --- PASS: TestX (0.00s)
                        x_test.go:6: LOG: X running
                    --- PASS: TestX/Y (0.00s)
                        x_test.go:8: LOG: Y running
                === RUN   TestXX
                --- PASS: TestXX (0.00s)
                        z_test.go:10: LOG: XX running
                === RUN   TestX
                === RUN   TestX/Y
                --- PASS: TestX (0.00s)
                        x_test.go:6: LOG: X running
                    --- PASS: TestX/Y (0.00s)
                        x_test.go:8: LOG: Y running
                === RUN   TestXX
                --- PASS: TestXX (0.00s)
                        z_test.go:10: LOG: XX running
                goos: linux
                goarch: amd64
                pkg: testregexp
                BenchmarkX/Y            2000000000               0.00 ns/op
                --- BENCH: BenchmarkX/Y
                        x_test.go:15: LOG: Y running N=1
                        x_test.go:15: LOG: Y running N=100
                        x_test.go:15: LOG: Y running N=10000
                        x_test.go:15: LOG: Y running N=1000000
                        x_test.go:15: LOG: Y running N=100000000
                        x_test.go:15: LOG: Y running N=2000000000
                BenchmarkX/Y            2000000000               0.00 ns/op
                --- BENCH: BenchmarkX/Y
                        x_test.go:15: LOG: Y running N=1
                        x_test.go:15: LOG: Y running N=2000000000
                --- BENCH: BenchmarkX
                        x_test.go:13: LOG: X running N=1
                --- BENCH: BenchmarkXX
                        z_test.go:18: LOG: XX running N=1
                PASS
                ok      testregexp      0.020s

        go_test.go:4793: reduced output:<<<
                === RUN   TestX
                === RUN   TestX/Y
                        x_test.go:6: LOG: X running
                        x_test.go:8: LOG: Y running
                === RUN   TestXX
                        z_test.go:10: LOG: XX running
                === RUN   TestX
                === RUN   TestX/Y
                        x_test.go:6: LOG: X running
                        x_test.go:8: LOG: Y running
                === RUN   TestXX
                        z_test.go:10: LOG: XX running
                --- BENCH: BenchmarkX/Y
                        x_test.go:15: LOG: Y running N=1
                        x_test.go:15: LOG: Y running N=100
                        x_test.go:15: LOG: Y running N=10000
                        x_test.go:15: LOG: Y running N=1000000
                        x_test.go:15: LOG: Y running N=100000000
                        x_test.go:15: LOG: Y running N=2000000000
                --- BENCH: BenchmarkX/Y
                        x_test.go:15: LOG: Y running N=1
                        x_test.go:15: LOG: Y running N=2000000000
                --- BENCH: BenchmarkX
                        x_test.go:13: LOG: X running N=1
                --- BENCH: BenchmarkXX
                        z_test.go:18: LOG: XX running N=1
                >>> want:<<<
                === RUN   TestX
                === RUN   TestX/Y
                        x_test.go:6: LOG: X running
                        x_test.go:8: LOG: Y running
                === RUN   TestXX
                        z_test.go:10: LOG: XX running
                === RUN   TestX
                === RUN   TestX/Y
                        x_test.go:6: LOG: X running
                        x_test.go:8: LOG: Y running
                === RUN   TestXX
                        z_test.go:10: LOG: XX running
                --- BENCH: BenchmarkX/Y
                        x_test.go:15: LOG: Y running N=1
                        x_test.go:15: LOG: Y running N=100
                        x_test.go:15: LOG: Y running N=10000
                        x_test.go:15: LOG: Y running N=1000000
                        x_test.go:15: LOG: Y running N=100000000
                        x_test.go:15: LOG: Y running N=2000000000
                --- BENCH: BenchmarkX/Y
                        x_test.go:15: LOG: Y running N=1
                        x_test.go:15: LOG: Y running N=100
                        x_test.go:15: LOG: Y running N=10000
                        x_test.go:15: LOG: Y running N=1000000
                        x_test.go:15: LOG: Y running N=100000000
                        x_test.go:15: LOG: Y running N=2000000000
                --- BENCH: BenchmarkX
                        x_test.go:13: LOG: X running N=1
                --- BENCH: BenchmarkXX
                        z_test.go:18: LOG: XX running N=1
                >>>
--- FAIL: TestDefaultGOPATH (0.02s)
        go_test.go:1972: running testgo [env GOPATH]
        go_test.go:1972: standard output:
        go_test.go:1972: /tmp/gotest006247972/home/go

        go_test.go:1979: running testgo [env GOPATH]
        go_test.go:1979: standard error:
        go_test.go:1979: vgo requires Go 1.10 but VGOROOT=/tmp/gotest006247972/home/go is not a Go 1.10 source tree

        go_test.go:1979: go [env GOPATH] failed unexpectedly: exit status 1
--- FAIL: TestAccidentalGitCheckout (7.20s)
        go_test.go:1472: running testgo [get -u vcs-test.golang.org/go/test1-svn-git]
        go_test.go:1472: standard error:
        go_test.go:1472: package vcs-test.golang.org/go/test1-svn-git/git-README-only/pkg: directory "/tmp/gotest674324945/src/vcs-test.golang.org/go/test1-svn-git/git-README-only" uses git, but parent "/tmp/gotest674324945/src/vcs-test.golang.org/go/test1-svn-git" uses svn

        go_test.go:1472: testgo failed as expected: exit status 1
        go_test.go:1475: running testgo [get -u vcs-test.golang.org/go/test2-svn-git/test2main]
        go_test.go:1475: standard error:
        go_test.go:1475: package vcs-test.golang.org/go/test2-svn-git/test2pkg/pkg: cannot find package "vcs-test.golang.org/go/test2-svn-git/test2pkg/pkg" in any of:
                        /usr/local/google/home/bcmills/go/src/vcs-test.golang.org/go/test2-svn-git/test2pkg/pkg (from $GOROOT)
                        /tmp/gotest674324945/src/vcs-test.golang.org/go/test2-svn-git/test2pkg/pkg (from $GOPATH)

        go_test.go:1475: testgo failed as expected: exit status 1
        go_test.go:1476: get did not fail for right reason
        go_test.go:1476: pattern src[\\/]vcs-test.* uses git, but parent .*src[\\/]vcs-test.* uses svn not found in standard error
FAIL
FAIL    golang.org/x/vgo/vendor/cmd/go  187.644s
?       golang.org/x/vgo/vendor/cmd/go/internal/base    [no test files]
?       golang.org/x/vgo/vendor/cmd/go/internal/bug     [no test files]
ok      golang.org/x/vgo/vendor/cmd/go/internal/cache   (cached)
?       golang.org/x/vgo/vendor/cmd/go/internal/cfg     [no test files]
?       golang.org/x/vgo/vendor/cmd/go/internal/clean   [no test files]
?       golang.org/x/vgo/vendor/cmd/go/internal/cmdflag [no test files]
ok      golang.org/x/vgo/vendor/cmd/go/internal/dirhash (cached)
?       golang.org/x/vgo/vendor/cmd/go/internal/doc     [no test files]
?       golang.org/x/vgo/vendor/cmd/go/internal/envcmd  [no test files]
?       golang.org/x/vgo/vendor/cmd/go/internal/fix     [no test files]
?       golang.org/x/vgo/vendor/cmd/go/internal/fmtcmd  [no test files]
ok      golang.org/x/vgo/vendor/cmd/go/internal/generate        (cached)
ok      golang.org/x/vgo/vendor/cmd/go/internal/get     (cached)
?       golang.org/x/vgo/vendor/cmd/go/internal/help    [no test files]
ok      golang.org/x/vgo/vendor/cmd/go/internal/imports (cached)
?       golang.org/x/vgo/vendor/cmd/go/internal/list    [no test files]
ok      golang.org/x/vgo/vendor/cmd/go/internal/load    (cached)
ok      golang.org/x/vgo/vendor/cmd/go/internal/modconv (cached)
SIGQUIT: quit
PC=0x45ea01 m=0 sigcode=0

goroutine 0 [idle]:
runtime.futex(0xb05de0, 0x80, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x7ffeae4aa9f0, 0x40bff2, ...)
        /usr/local/google/home/bcmills/go/src/runtime/sys_linux_amd64.s:531 +0x21
runtime.futexsleep(0xb05de0, 0x7ffe00000000, 0xffffffffffffffff)
        /usr/local/google/home/bcmills/go/src/runtime/os_linux.go:46 +0x4b
runtime.notesleep(0xb05de0)
        /usr/local/google/home/bcmills/go/src/runtime/lock_futex.go:151 +0xa2
runtime.stopm()
        /usr/local/google/home/bcmills/go/src/runtime/proc.go:2003 +0xe3
runtime.findrunnable(0xc00002f400, 0x0)
        /usr/local/google/home/bcmills/go/src/runtime/proc.go:2466 +0x4e0
runtime.schedule()
        /usr/local/google/home/bcmills/go/src/runtime/proc.go:2592 +0x13a
runtime.park_m(0xc000078600)
        /usr/local/google/home/bcmills/go/src/runtime/proc.go:2655 +0xae
runtime.mcall(0x0)
        /usr/local/google/home/bcmills/go/src/runtime/asm_amd64.s:299 +0x5b

goroutine 1 [chan receive, 9 minutes]:
testing.(*T).Run(0xc0000ec200, 0x811eb9, 0xc, 0x82a4e8, 0x48b546)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:879 +0x37a
testing.runTests.func1(0xc0000ec100)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:1119 +0x78
testing.tRunner(0xc0000ec100, 0xc0000a9d78)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:827 +0xbf
testing.runTests(0xc00014c720, 0xafc6e0, 0x7, 0x7, 0x499925)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:1117 +0x2a2
testing.(*M).Run(0xc0000d2280, 0x0)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:1034 +0x165
golang.org/x/vgo/vendor/cmd/go/internal/modfetch.testMain(0xc0000d2280, 0x0)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/coderepo_test.go:37 +0x105
golang.org/x/vgo/vendor/cmd/go/internal/modfetch.TestMain(0xc0000d2280)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/coderepo_test.go:26 +0x2b
main.main()
        _testmain.go:52 +0x13d

goroutine 5 [syscall, 9 minutes]:
os/signal.signal_recv(0x0)
        /usr/local/google/home/bcmills/go/src/runtime/sigqueue.go:139 +0x9c
os/signal.loop()
        /usr/local/google/home/bcmills/go/src/os/signal/signal_unix.go:23 +0x22
created by os/signal.init.0
        /usr/local/google/home/bcmills/go/src/os/signal/signal_unix.go:29 +0x41

goroutine 6 [chan receive, 9 minutes]:
testing.(*T).Run(0xc0000ec300, 0xc000447580, 0x1e, 0xc000492b00, 0x1)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:879 +0x37a
golang.org/x/vgo/vendor/cmd/go/internal/modfetch.TestCodeRepo(0xc0000ec200)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/coderepo_test.go:362 +0x317
testing.tRunner(0xc0000ec200, 0x82a4e8)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:827 +0xbf
created by testing.(*T).Run
        /usr/local/google/home/bcmills/go/src/testing/testing.go:878 +0x353

goroutine 8 [syscall, 9 minutes]:
syscall.Syscall6(0xf7, 0x1, 0x1f9ba, 0xc0000a6d50, 0x1000004, 0x0, 0x0, 0x82ad38, 0x20, 0xc0000a6dc8)
        /usr/local/google/home/bcmills/go/src/syscall/asm_linux_amd64.s:44 +0x5
os.(*Process).blockUntilWaitable(0xc0003cdb90, 0x4, 0xc0000a6eb8, 0xc0003cdb90)
        /usr/local/google/home/bcmills/go/src/os/wait_waitid.go:31 +0x98
os.(*Process).wait(0xc0003cdb90, 0x9, 0xc, 0xc000429ba0)
        /usr/local/google/home/bcmills/go/src/os/exec_unix.go:22 +0x39
os.(*Process).Wait(0xc0003cdb90, 0x82a8f8, 0x82a900, 0x82a8f0)
        /usr/local/google/home/bcmills/go/src/os/exec.go:125 +0x2b
os/exec.(*Cmd).Wait(0xc000173600, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:463 +0x5b
os/exec.(*Cmd).Run(0xc000173600, 0x3, 0xc0003b44d0)
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:307 +0x5c
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/codehost.Run(0x0, 0x0, 0xc0000a7100, 0x4, 0x4, 0xc0000a70d8, 0x444194, 0xc0004d23f2, 0x2e, 0x30)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/codehost/codehost.go:172 +0x195
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo.(*repo).loadRefs(0xc00006c180)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo/fetch.go:99 +0xfe
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo.(*repo).loadRefs-fm()
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo/fetch.go:124 +0x2a
sync.(*Once).Do(0xc00006c1bc, 0xc0000a7450)
        /usr/local/google/home/bcmills/go/src/sync/once.go:44 +0xb3
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo.(*repo).statOrArchive(0xc00006c180, 0x80fea7, 0x6, 0xc0004f2010, 0x1, 0x1, 0x0, 0x0, 0x0, 0x0, ...)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo/fetch.go:184 +0x6d
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo.(*repo).Stat(0xc00006c180, 0x80fea7, 0x6, 0x80fea7, 0x6, 0x0)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo/fetch.go:338 +0x94
golang.org/x/vgo/vendor/cmd/go/internal/modfetch.(*codeRepo).Stat(0xc000462080, 0x80fea7, 0x6, 0xc000462001, 0x0, 0x0)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/coderepo.go:130 +0xcd
golang.org/x/vgo/vendor/cmd/go/internal/modfetch.TestCodeRepo.func1(0xc0000ec300)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/coderepo_test.go:379 +0x2e1
testing.tRunner(0xc0000ec300, 0xc000492b00)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:827 +0xbf
created by testing.(*T).Run
        /usr/local/google/home/bcmills/go/src/testing/testing.go:878 +0x353

goroutine 11 [IO wait, 9 minutes]:
internal/poll.runtime_pollWait(0x7f9bd64f0ea0, 0x72, 0xc0000494e8)
        /usr/local/google/home/bcmills/go/src/runtime/netpoll.go:173 +0x66
internal/poll.(*pollDesc).wait(0xc0000924c8, 0x72, 0xffffffffffffff01, 0x878020, 0xac8508)
        /usr/local/google/home/bcmills/go/src/internal/poll/fd_poll_runtime.go:85 +0x9a
internal/poll.(*pollDesc).waitRead(0xc0000924c8, 0xc0002f2001, 0x200, 0x200)
        /usr/local/google/home/bcmills/go/src/internal/poll/fd_poll_runtime.go:90 +0x3d
internal/poll.(*FD).Read(0xc0000924b0, 0xc0002f2000, 0x200, 0x200, 0x0, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/internal/poll/fd_unix.go:163 +0x179
os.(*File).read(0xc00000e0a8, 0xc0002f2000, 0x200, 0x200, 0xc0002f2000, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/os/file_unix.go:237 +0x4e
os.(*File).Read(0xc00000e0a8, 0xc0002f2000, 0x200, 0x200, 0xc000049658, 0x4945dc, 0xc000049660)
        /usr/local/google/home/bcmills/go/src/os/file.go:108 +0x69
bytes.(*Buffer).ReadFrom(0xc0000d0150, 0x8775c0, 0xc00000e0a8, 0x7f9bd649d820, 0xc0000d0150, 0x1)
        /usr/local/google/home/bcmills/go/src/bytes/buffer.go:206 +0xb4
io.copyBuffer(0x876fa0, 0xc0000d0150, 0x8775c0, 0xc00000e0a8, 0x0, 0x0, 0x0, 0xc0000921e0, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/io/io.go:388 +0x303
io.Copy(0x876fa0, 0xc0000d0150, 0x8775c0, 0xc00000e0a8, 0x406575, 0xc00006c1e0, 0xc0000497b0)
        /usr/local/google/home/bcmills/go/src/io/io.go:364 +0x5a
os/exec.(*Cmd).writerDescriptor.func1(0xc00006c1e0, 0xc0000497b0)
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:277 +0x4d
os/exec.(*Cmd).Start.func1(0xc000173600, 0xc000492c60)
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:398 +0x27
created by os/exec.(*Cmd).Start
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:397 +0x58c

goroutine 12 [IO wait, 9 minutes]:
internal/poll.runtime_pollWait(0x7f9bd64f0c30, 0x72, 0xc0000434e8)
        /usr/local/google/home/bcmills/go/src/runtime/netpoll.go:173 +0x66
internal/poll.(*pollDesc).wait(0xc0000925b8, 0x72, 0xffffffffffffff01, 0x878020, 0xac8508)
        /usr/local/google/home/bcmills/go/src/internal/poll/fd_poll_runtime.go:85 +0x9a
internal/poll.(*pollDesc).waitRead(0xc0000925b8, 0xc0002f6001, 0x200, 0x200)
        /usr/local/google/home/bcmills/go/src/internal/poll/fd_poll_runtime.go:90 +0x3d
internal/poll.(*FD).Read(0xc0000925a0, 0xc0002f6000, 0x200, 0x200, 0x0, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/internal/poll/fd_unix.go:163 +0x179
os.(*File).read(0xc00000e0c0, 0xc0002f6000, 0x200, 0x200, 0xc0002f6000, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/os/file_unix.go:237 +0x4e
os.(*File).Read(0xc00000e0c0, 0xc0002f6000, 0x200, 0x200, 0x0, 0x0, 0xc000043660)
        /usr/local/google/home/bcmills/go/src/os/file.go:108 +0x69
bytes.(*Buffer).ReadFrom(0xc0000d00e0, 0x8775c0, 0xc00000e0c0, 0x7f9bd649d820, 0xc0000d00e0, 0x1)
        /usr/local/google/home/bcmills/go/src/bytes/buffer.go:206 +0xb4
io.copyBuffer(0x876fa0, 0xc0000d00e0, 0x8775c0, 0xc00000e0c0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/io/io.go:388 +0x303
io.Copy(0x876fa0, 0xc0000d00e0, 0x8775c0, 0xc00000e0c0, 0x0, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/io/io.go:364 +0x5a
os/exec.(*Cmd).writerDescriptor.func1(0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:277 +0x4d
os/exec.(*Cmd).Start.func1(0xc000173600, 0xc000492ca0)
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:398 +0x27
created by os/exec.(*Cmd).Start
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:397 +0x58c

rax    0xca
rbx    0xb05ca0
rcx    0x45ea03
rdx    0x0
rdi    0xb05de0
rsi    0x80
rbp    0x7ffeae4aa9b8
rsp    0x7ffeae4aa970
r8     0x0
r9     0x0
r10    0x0
r11    0x286
r12    0x55
r13    0xe
r14    0xc000049700
r15    0x0
rip    0x45ea01
rflags 0x286
cs     0x33
fs     0x0
gs     0x0
*** Test killed with quit: ran too long (10m0s).
FAIL    golang.org/x/vgo/vendor/cmd/go/internal/modfetch        600.055s
?       golang.org/x/vgo/vendor/cmd/go/internal/modfetch/bitbucket      [no test files]
?       golang.org/x/vgo/vendor/cmd/go/internal/modfetch/codehost       [no test files]
?       golang.org/x/vgo/vendor/cmd/go/internal/modfetch/github [no test files]
SIGQUIT: quit
PC=0x45a641 m=0 sigcode=0

goroutine 0 [idle]:
runtime.futex(0x671480, 0x80, 0x0, 0x0, 0x7f0000000000, 0x20300000000000, 0x0, 0x0, 0x7ffd55d9cd80, 0x40a082, ...)
        /usr/local/google/home/bcmills/go/src/runtime/sys_linux_amd64.s:531 +0x21
runtime.futexsleep(0x671480, 0x7ffd00000000, 0xffffffffffffffff)
        /usr/local/google/home/bcmills/go/src/runtime/os_linux.go:46 +0x4b
runtime.notesleep(0x671480)
        /usr/local/google/home/bcmills/go/src/runtime/lock_futex.go:151 +0xa2
runtime.stopm()
        /usr/local/google/home/bcmills/go/src/runtime/proc.go:2003 +0xe3
runtime.findrunnable(0xc000026500, 0x0)
        /usr/local/google/home/bcmills/go/src/runtime/proc.go:2466 +0x4e0
runtime.schedule()
        /usr/local/google/home/bcmills/go/src/runtime/proc.go:2592 +0x13a
runtime.park_m(0xc0002c8480)
        /usr/local/google/home/bcmills/go/src/runtime/proc.go:2655 +0xae
runtime.mcall(0x0)
        /usr/local/google/home/bcmills/go/src/runtime/asm_amd64.s:299 +0x5b

goroutine 1 [chan receive]:
testing.(*T).Run(0xc00013c600, 0x567157, 0xb, 0x56fb30, 0x479e01)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:879 +0x37a
testing.runTests.func1(0xc0000de000)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:1119 +0x78
testing.tRunner(0xc0000de000, 0xc000053c98)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:827 +0xbf
testing.runTests(0xc0000cc020, 0x66c9a0, 0x5, 0x5, 0x40b31f)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:1117 +0x2a2
testing.(*M).Run(0xc000094000, 0x0)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:1034 +0x165
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo.testMain(0xc000094000, 0x0)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo/fetch_test.go:50 +0x3da
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo.TestMain(0xc000094000)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo/fetch_test.go:22 +0x2b
main.main()
        _testmain.go:48 +0x13d

goroutine 132 [chan receive]:
testing.(*T).Run(0xc0000dec00, 0xc00036a140, 0x34, 0xc0000d10e0, 0x1)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:879 +0x37a
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo.TestReadZip(0xc00013c600)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo/fetch_test.go:342 +0x1bd
testing.tRunner(0xc00013c600, 0x56fb30)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:827 +0xbf
created by testing.(*T).Run
        /usr/local/google/home/bcmills/go/src/testing/testing.go:878 +0x353

goroutine 234 [syscall]:
syscall.Syscall6(0xf7, 0x1, 0x2028a, 0xc0000bce68, 0x1000004, 0x0, 0x0, 0x20, 0xc000291480, 0x0)
        /usr/local/google/home/bcmills/go/src/syscall/asm_linux_amd64.s:44 +0x5
os.(*Process).blockUntilWaitable(0xc000303290, 0x4, 0xc0000bcfd0, 0xc000303290)
        /usr/local/google/home/bcmills/go/src/os/wait_waitid.go:31 +0x98
os.(*Process).wait(0xc000303290, 0x9, 0xc, 0xc0000d11d0)
        /usr/local/google/home/bcmills/go/src/os/exec_unix.go:22 +0x39
os.(*Process).Wait(0xc000303290, 0x56fbc8, 0x56fbd0, 0x56fbc0)
        /usr/local/google/home/bcmills/go/src/os/exec.go:125 +0x2b
os/exec.(*Cmd).Wait(0xc0002e0c60, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:463 +0x5b
os/exec.(*Cmd).Run(0xc0002e0c60, 0x3, 0xc0000c9d50)
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:307 +0x5c
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/codehost.Run(0x0, 0x0, 0xc0000bd218, 0x4, 0x4, 0x40b31f, 0xc000000073, 0xc0000bd228, 0x0, 0x0)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/codehost/codehost.go:172 +0x195
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo.(*repo).loadRefs(0xc0000e5f20)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo/fetch.go:99 +0xfe
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo.(*repo).loadRefs-fm()
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo/fetch.go:124 +0x2a
sync.(*Once).Do(0xc0000e5f5c, 0xc0000bd568)
        /usr/local/google/home/bcmills/go/src/sync/once.go:44 +0xb3
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo.(*repo).statOrArchive(0xc0000e5f20, 0x5678df, 0xd, 0xc0002913a0, 0x2, 0x2, 0x0, 0x2, 0x2b, 0xc0002a8f00, ...)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo/fetch.go:184 +0x6d
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo.(*repo).ReadZip(0xc0000e5f20, 0x5678df, 0xd, 0x56629a, 0x6, 0x186a0, 0x38, 0xc0002a24f0, 0x44742f, 0x6550d4, ...)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo/fetch.go:369 +0xa8
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo.TestReadZip.func1(0xc0000dec00)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo/fetch_test.go:296 +0x118
testing.tRunner(0xc0000dec00, 0xc0000d10e0)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:827 +0xbf
created by testing.(*T).Run
        /usr/local/google/home/bcmills/go/src/testing/testing.go:878 +0x353

goroutine 238 [IO wait]:
internal/poll.runtime_pollWait(0x7f005976fea0, 0x72, 0xc000043ce8)
        /usr/local/google/home/bcmills/go/src/runtime/netpoll.go:173 +0x66
internal/poll.(*pollDesc).wait(0xc00026be68, 0x72, 0xffffffffffffff01, 0x588bc0, 0x658180)
        /usr/local/google/home/bcmills/go/src/internal/poll/fd_poll_runtime.go:85 +0x9a
internal/poll.(*pollDesc).waitRead(0xc00026be68, 0xc00034e601, 0x200, 0x200)
        /usr/local/google/home/bcmills/go/src/internal/poll/fd_poll_runtime.go:90 +0x3d
internal/poll.(*FD).Read(0xc00026be50, 0xc00034e600, 0x200, 0x200, 0x0, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/internal/poll/fd_unix.go:163 +0x179
os.(*File).read(0xc0000d6790, 0xc00034e600, 0x200, 0x200, 0xc00034e600, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/os/file_unix.go:237 +0x4e
os.(*File).Read(0xc0000d6790, 0xc00034e600, 0x200, 0x200, 0xc000043e58, 0x47f2fc, 0xc000043e60)
        /usr/local/google/home/bcmills/go/src/os/file.go:108 +0x69
bytes.(*Buffer).ReadFrom(0xc0002fc4d0, 0x588a00, 0xc0000d6790, 0x7f005972b020, 0xc0002fc4d0, 0xc0000ac401)
        /usr/local/google/home/bcmills/go/src/bytes/buffer.go:206 +0xb4
io.copyBuffer(0x5888c0, 0xc0002fc4d0, 0x588a00, 0xc0000d6790, 0x0, 0x0, 0x0, 0xc00026a870, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/io/io.go:388 +0x303
io.Copy(0x5888c0, 0xc0002fc4d0, 0x588a00, 0xc0000d6790, 0x404865, 0xc0000e5320, 0xc000043fb0)
        /usr/local/google/home/bcmills/go/src/io/io.go:364 +0x5a
os/exec.(*Cmd).writerDescriptor.func1(0xc0000e5320, 0xc000043fb0)
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:277 +0x4d
os/exec.(*Cmd).Start.func1(0xc0002e0c60, 0xc000291440)
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:398 +0x27
created by os/exec.(*Cmd).Start
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:397 +0x58c

goroutine 237 [IO wait]:
internal/poll.runtime_pollWait(0x7f005976fc30, 0x72, 0xc0002a1ce8)
        /usr/local/google/home/bcmills/go/src/runtime/netpoll.go:173 +0x66
internal/poll.(*pollDesc).wait(0xc00026bdc8, 0x72, 0xffffffffffffff01, 0x588bc0, 0x658180)
        /usr/local/google/home/bcmills/go/src/internal/poll/fd_poll_runtime.go:85 +0x9a
internal/poll.(*pollDesc).waitRead(0xc00026bdc8, 0xc00034e401, 0x200, 0x200)
        /usr/local/google/home/bcmills/go/src/internal/poll/fd_poll_runtime.go:90 +0x3d
internal/poll.(*FD).Read(0xc00026bdb0, 0xc00034e400, 0x200, 0x200, 0x0, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/internal/poll/fd_unix.go:163 +0x179
os.(*File).read(0xc0000d6778, 0xc00034e400, 0x200, 0x200, 0xc00034e400, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/os/file_unix.go:237 +0x4e
os.(*File).Read(0xc0000d6778, 0xc00034e400, 0x200, 0x200, 0xc0002a1e58, 0x47f2fc, 0xc0002a1e60)
        /usr/local/google/home/bcmills/go/src/os/file.go:108 +0x69
bytes.(*Buffer).ReadFrom(0xc0002fc540, 0x588a00, 0xc0000d6778, 0x7f005972b020, 0xc0002fc540, 0x1)
        /usr/local/google/home/bcmills/go/src/bytes/buffer.go:206 +0xb4
io.copyBuffer(0x5888c0, 0xc0002fc540, 0x588a00, 0xc0000d6778, 0x0, 0x0, 0x0, 0xc00017f630, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/io/io.go:388 +0x303
io.Copy(0x5888c0, 0xc0002fc540, 0x588a00, 0xc0000d6778, 0x404865, 0xc000176a80, 0xc0002a1fb0)
        /usr/local/google/home/bcmills/go/src/io/io.go:364 +0x5a
os/exec.(*Cmd).writerDescriptor.func1(0xc000176a80, 0xc0002a1fb0)
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:277 +0x4d
os/exec.(*Cmd).Start.func1(0xc0002e0c60, 0xc000291400)
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:398 +0x27
created by os/exec.(*Cmd).Start
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:397 +0x58c

rax    0xca
rbx    0x671340
rcx    0x45a643
rdx    0x0
rdi    0x671480
rsi    0x80
rbp    0x7ffd55d9cd48
rsp    0x7ffd55d9cd00
r8     0x0
r9     0x0
r10    0x0
r11    0x286
r12    0x0
r13    0x10
r14    0x10
r15    0x10
rip    0x45a641
rflags 0x286
cs     0x33
fs     0x0
gs     0x0
*** Test killed with quit: ran too long (10m0s).
FAIL    golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo        600.038s
?       golang.org/x/vgo/vendor/cmd/go/internal/modfetch/googlesource   [no test files]
ok      golang.org/x/vgo/vendor/cmd/go/internal/modfile (cached)
?       golang.org/x/vgo/vendor/cmd/go/internal/modinfo [no test files]
ok      golang.org/x/vgo/vendor/cmd/go/internal/module  (cached)
ok      golang.org/x/vgo/vendor/cmd/go/internal/mvs     (cached)
?       golang.org/x/vgo/vendor/cmd/go/internal/run     [no test files]
ok      golang.org/x/vgo/vendor/cmd/go/internal/search  (cached)
ok      golang.org/x/vgo/vendor/cmd/go/internal/semver  (cached)
?       golang.org/x/vgo/vendor/cmd/go/internal/str     [no test files]
?       golang.org/x/vgo/vendor/cmd/go/internal/test    [no test files]
?       golang.org/x/vgo/vendor/cmd/go/internal/tool    [no test files]
?       golang.org/x/vgo/vendor/cmd/go/internal/version [no test files]
?       golang.org/x/vgo/vendor/cmd/go/internal/vet     [no test files]
?       golang.org/x/vgo/vendor/cmd/go/internal/vgo     [no test files]
?       golang.org/x/vgo/vendor/cmd/go/internal/web     [no test files]
ok      golang.org/x/vgo/vendor/cmd/go/internal/web2    (cached)
?       golang.org/x/vgo/vendor/cmd/go/internal/webtest [no test files]
ok      golang.org/x/vgo/vendor/cmd/go/internal/work    (cached)
@bcmills

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2018

go test -p 1 ./... suggests that this is coming from the modfetch test.

Username for 'https://github.com': ^Z
[1]+  Stopped                 go test -p 1 ./...
~/src/golang.org/x/vgo/vendor/cmd/go$ pstree $$
bash─┬─go─┬─modfetch.test─┬─git───git-remote-http
     │    │               └─12*[{modfetch.test}]
     │    └─16*[{go}]
     └─pstree
@bcmills

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2018

modfetch/gitrepo also hangs. I killed the test with SIGQUIT at the prompt and got the attached stack trace in TestReadZip.

go test ./internal/modfetch/gitrepo
SIGQUIT: quit
PC=0x4735a8 m=5 sigcode=0

goroutine 229 [syscall]:
syscall.Syscall6(0xf7, 0x1, 0x3b2ef, 0xc000052e68, 0x1000004, 0x0, 0x0, 0x20, 0xc0003124c0, 0x0)
        /usr/local/google/home/bcmills/go/src/syscall/asm_linux_amd64.s:44 +0x5 fp=0xc000052e10 sp=0xc000052e08 pc=0x473585
os.(*Process).blockUntilWaitable(0xc0003072f0, 0x4, 0xc000052fd0, 0xc0003072f0)
        /usr/local/google/home/bcmills/go/src/os/wait_waitid.go:31 +0x98 fp=0xc000052f08 sp=0xc000052e10 pc=0x485ab8
os.(*Process).wait(0xc0003072f0, 0x9, 0xc, 0xc000114ce0)
        /usr/local/google/home/bcmills/go/src/os/exec_unix.go:22 +0x39 fp=0xc000052f80 sp=0xc000052f08 pc=0x481b29
os.(*Process).Wait(0xc0003072f0, 0x56fbe0, 0x56fbe8, 0x56fbd8)
        /usr/local/google/home/bcmills/go/src/os/exec.go:125 +0x2b fp=0xc000052fb0 sp=0xc000052f80 pc=0x4811db
os/exec.(*Cmd).Wait(0xc00036e000, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:463 +0x5b fp=0xc000053028 sp=0xc000052fb0 pc=0x5083bb
os/exec.(*Cmd).Run(0xc00036e000, 0x3, 0xc0000dd350)
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:307 +0x5c fp=0xc000053050 sp=0xc000053028 pc=0x5078fc
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/codehost.Run(0x0, 0x0, 0xc000053218, 0x4, 0x4, 0x40b3af, 0xc000000073, 0xc000053228, 0x0, 0x0)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/codehost/codehost.go:172 +0x195 fp=0xc000053160 sp=0xc000053050 pc=0x50a585
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo.(*repo).loadRefs(0xc00013b320)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo/fetch.go:99 +0xfe fp=0xc0000532c8 sp=0xc000053160 pc=0x50c69e
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo.(*repo).loadRefs-fm()
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo/fetch.go:124 +0x2a fp=0xc0000532e0 sp=0xc0000532c8 pc=0x51495a
sync.(*Once).Do(0xc00013b35c, 0xc000053568)
        /usr/local/google/home/bcmills/go/src/sync/once.go:44 +0xb3 fp=0xc000053310 sp=0xc0000532e0 pc=0x46bf13
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo.(*repo).statOrArchive(0xc00013b320, 0x5678c5, 0xd, 0xc0003123e0, 0x2, 0x2, 0x0, 0x2, 0x2b, 0xc000368000, ...)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo/fetch.go:184 +0x6d fp=0xc000053b10 sp=0xc000053310 pc=0x50d3fd
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo.(*repo).ReadZip(0xc00013b320, 0x5678c5, 0xd, 0x566277, 0x6, 0x186a0, 0x38, 0xc0001b6cf0, 0x4474ef, 0x65511c, ...)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo/fetch.go:369 +0xa8 fp=0xc000053c60 sp=0xc000053b10 pc=0x50fc38
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo.TestReadZip.func1(0xc00014c800)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo/fetch_test.go:296 +0x118 fp=0xc000053fa8 sp=0xc000053c60 pc=0x512bd8
testing.tRunner(0xc00014c800, 0xc000114bf0)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:827 +0xbf fp=0xc000053fd0 sp=0xc000053fa8 pc=0x4bec4f
runtime.goexit()
        /usr/local/google/home/bcmills/go/src/runtime/asm_amd64.s:1333 +0x1 fp=0xc000053fd8 sp=0xc000053fd0 pc=0x458a11
created by testing.(*T).Run
        /usr/local/google/home/bcmills/go/src/testing/testing.go:878 +0x353

goroutine 1 [chan receive]:
testing.(*T).Run(0xc00014c300, 0x56713d, 0xb, 0x56fb48, 0x47a001)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:879 +0x37a
testing.runTests.func1(0xc0000fc000)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:1119 +0x78
testing.tRunner(0xc0000fc000, 0xc000079c98)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:827 +0xbf
testing.runTests(0xc00000a180, 0x66c9a0, 0x5, 0x5, 0x40b3af)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:1117 +0x2a2
testing.(*M).Run(0xc0000c4000, 0x0)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:1034 +0x165
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo.testMain(0xc0000c4000, 0x0)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo/fetch_test.go:50 +0x3da
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo.TestMain(0xc0000c4000)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo/fetch_test.go:22 +0x2b
main.main()
        _testmain.go:48 +0x13d

goroutine 86 [chan receive]:
testing.(*T).Run(0xc00014c800, 0xc0002dab80, 0x34, 0xc000114bf0, 0x1)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:879 +0x37a
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo.TestReadZip(0xc00014c300)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo/fetch_test.go:342 +0x1bd
testing.tRunner(0xc00014c300, 0x56fb48)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:827 +0xbf
created by testing.(*T).Run
        /usr/local/google/home/bcmills/go/src/testing/testing.go:878 +0x353

goroutine 233 [IO wait]:
internal/poll.runtime_pollWait(0x7fcf30898c30, 0x72, 0xc0001434e8)
        /usr/local/google/home/bcmills/go/src/runtime/netpoll.go:173 +0x66
internal/poll.(*pollDesc).wait(0xc0002ded38, 0x72, 0xffffffffffffff01, 0x588be0, 0x658180)
        /usr/local/google/home/bcmills/go/src/internal/poll/fd_poll_runtime.go:85 +0x9a
internal/poll.(*pollDesc).waitRead(0xc0002ded38, 0xc000309c01, 0x200, 0x200)
        /usr/local/google/home/bcmills/go/src/internal/poll/fd_poll_runtime.go:90 +0x3d
internal/poll.(*FD).Read(0xc0002ded20, 0xc000309c00, 0x200, 0x200, 0x0, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/internal/poll/fd_unix.go:163 +0x179
os.(*File).read(0xc000124570, 0xc000309c00, 0x200, 0x200, 0xc000309c00, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/os/file_unix.go:237 +0x4e
os.(*File).Read(0xc000124570, 0xc000309c00, 0x200, 0x200, 0xc000143658, 0x47f51c, 0xc000143660)
        /usr/local/google/home/bcmills/go/src/os/file.go:108 +0x69
bytes.(*Buffer).ReadFrom(0xc0001178f0, 0x588a20, 0xc000124570, 0x7fcf30854020, 0xc0001178f0, 0x1)
        /usr/local/google/home/bcmills/go/src/bytes/buffer.go:206 +0xb4
io.copyBuffer(0x5888e0, 0xc0001178f0, 0x588a20, 0xc000124570, 0x0, 0x0, 0x0, 0xc0002aeb40, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/io/io.go:388 +0x303
io.Copy(0x5888e0, 0xc0001178f0, 0x588a20, 0xc000124570, 0x404865, 0xc000175440, 0xc0001437b0)
        /usr/local/google/home/bcmills/go/src/io/io.go:364 +0x5a
os/exec.(*Cmd).writerDescriptor.func1(0xc000175440, 0xc0001437b0)
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:277 +0x4d
os/exec.(*Cmd).Start.func1(0xc00036e000, 0xc000312480)
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:398 +0x27
created by os/exec.(*Cmd).Start
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:397 +0x58c

goroutine 232 [IO wait]:
internal/poll.runtime_pollWait(0x7fcf30898d00, 0x72, 0xc0001b64e8)
        /usr/local/google/home/bcmills/go/src/runtime/netpoll.go:173 +0x66
internal/poll.(*pollDesc).wait(0xc0002dec98, 0x72, 0xffffffffffffff01, 0x588be0, 0x658180)
        /usr/local/google/home/bcmills/go/src/internal/poll/fd_poll_runtime.go:85 +0x9a
internal/poll.(*pollDesc).waitRead(0xc0002dec98, 0xc000309a01, 0x200, 0x200)
        /usr/local/google/home/bcmills/go/src/internal/poll/fd_poll_runtime.go:90 +0x3d
internal/poll.(*FD).Read(0xc0002dec80, 0xc000309a00, 0x200, 0x200, 0x0, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/internal/poll/fd_unix.go:163 +0x179
os.(*File).read(0xc000124558, 0xc000309a00, 0x200, 0x200, 0xc000309a00, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/os/file_unix.go:237 +0x4e
os.(*File).Read(0xc000124558, 0xc000309a00, 0x200, 0x200, 0xc0001b6658, 0x47f51c, 0xc0001b6660)
        /usr/local/google/home/bcmills/go/src/os/file.go:108 +0x69
bytes.(*Buffer).ReadFrom(0xc000117960, 0x588a20, 0xc000124558, 0x7fcf30854020, 0xc000117960, 0x1)
        /usr/local/google/home/bcmills/go/src/bytes/buffer.go:206 +0xb4
io.copyBuffer(0x5888e0, 0xc000117960, 0x588a20, 0xc000124558, 0x0, 0x0, 0x0, 0xc0002aebe0, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/io/io.go:388 +0x303
io.Copy(0x5888e0, 0xc000117960, 0x588a20, 0xc000124558, 0x404865, 0xc000175440, 0xc0001b67b0)
        /usr/local/google/home/bcmills/go/src/io/io.go:364 +0x5a
os/exec.(*Cmd).writerDescriptor.func1(0xc000175440, 0xc0001b67b0)
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:277 +0x4d
os/exec.(*Cmd).Start.func1(0xc00036e000, 0xc000312440)
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:398 +0x27
created by os/exec.(*Cmd).Start
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:397 +0x58c

rax    0xf7
rbx    0x0
rcx    0x4735aa
rdx    0xc000052e68
rdi    0x1
rsi    0x3b2ef
rbp    0xc000052ef8
rsp    0xc000052e08
r8     0x0
r9     0x0
r10    0x1000004
r11    0x216
r12    0x4
r13    0xda
r14    0x585fff
r15    0x38
rip    0x4735a8
rflags 0x216
cs     0x33
fs     0x0
gs     0x0
FAIL    golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo        29.237s
@bcmills

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2018

modfetch/gitrepo seems to be failing on the https://github.com/rsc/vgotest1 test case. I think the problem may be that the vgotest1 repo isn't set to be public, since I don't see it in a search.

@rsc, could you double-check?

@bcmills

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2018

Here's the SIGQUIT trace for modfetch itself.

go test ./internal/modfetch
SIGQUIT: quit
PC=0x45ec21 m=7 sigcode=0

goroutine 0 [idle]:
runtime.futex(0xc0000e8f40, 0x80, 0x0, 0x0, 0x0, 0xc000280000, 0x0, 0x0, 0x7f1635628d88, 0x40c082, ...)
        /usr/local/google/home/bcmills/go/src/runtime/sys_linux_amd64.s:531 +0x21
runtime.futexsleep(0xc0000e8f40, 0xc000000000, 0xffffffffffffffff)
        /usr/local/google/home/bcmills/go/src/runtime/os_linux.go:46 +0x4b
runtime.notesleep(0xc0000e8f40)
        /usr/local/google/home/bcmills/go/src/runtime/lock_futex.go:151 +0xa2
runtime.stopm()
        /usr/local/google/home/bcmills/go/src/runtime/proc.go:2009 +0xe3
runtime.findrunnable(0xc00002f400, 0x0)
        /usr/local/google/home/bcmills/go/src/runtime/proc.go:2472 +0x4e0
runtime.schedule()
        /usr/local/google/home/bcmills/go/src/runtime/proc.go:2598 +0x13a
runtime.park_m(0xc000450180)
        /usr/local/google/home/bcmills/go/src/runtime/proc.go:2661 +0xae
runtime.mcall(0x800000)
        /usr/local/google/home/bcmills/go/src/runtime/asm_amd64.s:299 +0x5b

goroutine 1 [chan receive]:
testing.(*T).Run(0xc0000ea200, 0x813fc1, 0xc, 0x82c620, 0x48b796)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:879 +0x37a
testing.runTests.func1(0xc0000ea100)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:1119 +0x78
testing.tRunner(0xc0000ea100, 0xc0000a9d78)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:827 +0xbf
testing.runTests(0xc00014c720, 0xaff6e0, 0x7, 0x7, 0x499b75)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:1117 +0x2a2
testing.(*M).Run(0xc0000d0280, 0x0)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:1034 +0x165
golang.org/x/vgo/vendor/cmd/go/internal/modfetch.testMain(0xc0000d0280, 0x0)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/coderepo_test.go:37 +0x105
golang.org/x/vgo/vendor/cmd/go/internal/modfetch.TestMain(0xc0000d0280)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/coderepo_test.go:26 +0x2b
main.main()
        _testmain.go:52 +0x13d

goroutine 5 [syscall]:
os/signal.signal_recv(0x0)
        /usr/local/google/home/bcmills/go/src/runtime/sigqueue.go:139 +0x9c
os/signal.loop()
        /usr/local/google/home/bcmills/go/src/os/signal/signal_unix.go:23 +0x22
created by os/signal.init.0
        /usr/local/google/home/bcmills/go/src/os/signal/signal_unix.go:29 +0x41

goroutine 6 [chan receive]:
testing.(*T).Run(0xc0000ea300, 0xc00048fc00, 0x1e, 0xc0004b0600, 0x1)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:879 +0x37a
golang.org/x/vgo/vendor/cmd/go/internal/modfetch.TestCodeRepo(0xc0000ea200)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/coderepo_test.go:362 +0x317
testing.tRunner(0xc0000ea200, 0x82c620)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:827 +0xbf
created by testing.(*T).Run
        /usr/local/google/home/bcmills/go/src/testing/testing.go:878 +0x353

goroutine 11 [syscall]:
syscall.Syscall6(0xf7, 0x1, 0x3bbd9, 0xc0000a6d50, 0x1000004, 0x0, 0x0, 0x20, 0xc00014c780, 0x0)
        /usr/local/google/home/bcmills/go/src/syscall/asm_linux_amd64.s:44 +0x5
os.(*Process).blockUntilWaitable(0xc00035ac90, 0x4, 0xc0000a6eb8, 0xc00035ac90)
        /usr/local/google/home/bcmills/go/src/os/wait_waitid.go:31 +0x98
os.(*Process).wait(0xc00035ac90, 0x9, 0xc, 0xc0002ba080)
        /usr/local/google/home/bcmills/go/src/os/exec_unix.go:22 +0x39
os.(*Process).Wait(0xc00035ac90, 0x82ca30, 0x82ca38, 0x82ca28)
        /usr/local/google/home/bcmills/go/src/os/exec.go:125 +0x2b
os/exec.(*Cmd).Wait(0xc000242160, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:463 +0x5b
os/exec.(*Cmd).Run(0xc000242160, 0x3, 0xc000275990)
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:307 +0x5c
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/codehost.Run(0x0, 0x0, 0xc0000a7100, 0x4, 0x4, 0xc0000a70d8, 0x444254, 0xc0003a9d12, 0x2e, 0x30)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/codehost/codehost.go:172 +0x195
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo.(*repo).loadRefs(0xc00006c180)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo/fetch.go:99 +0xfe
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo.(*repo).loadRefs-fm()
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo/fetch.go:124 +0x2a
sync.(*Once).Do(0xc00006c1bc, 0xc0000a7450)
        /usr/local/google/home/bcmills/go/src/sync/once.go:44 +0xb3
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo.(*repo).statOrArchive(0xc00006c180, 0x811fa6, 0x6, 0xc0002ba010, 0x1, 0x1, 0x0, 0x0, 0x0, 0x0, ...)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo/fetch.go:184 +0x6d
golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo.(*repo).Stat(0xc00006c180, 0x811fa6, 0x6, 0x811fa6, 0x6, 0x0)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/gitrepo/fetch.go:338 +0x94
golang.org/x/vgo/vendor/cmd/go/internal/modfetch.(*codeRepo).Stat(0xc000452080, 0x811fa6, 0x6, 0xc000452001, 0x0, 0x0)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/coderepo.go:130 +0xcd
golang.org/x/vgo/vendor/cmd/go/internal/modfetch.TestCodeRepo.func1(0xc0000ea300)
        /usr/local/google/home/bcmills/src/golang.org/x/vgo/vendor/cmd/go/internal/modfetch/coderepo_test.go:379 +0x2e1
testing.tRunner(0xc0000ea300, 0xc0004b0600)
        /usr/local/google/home/bcmills/go/src/testing/testing.go:827 +0xbf
created by testing.(*T).Run
        /usr/local/google/home/bcmills/go/src/testing/testing.go:878 +0x353

goroutine 22 [IO wait]:
internal/poll.runtime_pollWait(0x7f163a779d00, 0x72, 0xc000284ce8)
        /usr/local/google/home/bcmills/go/src/runtime/netpoll.go:173 +0x66
internal/poll.(*pollDesc).wait(0xc000428068, 0x72, 0xffffffffffffff01, 0x87a3e0, 0xacb508)
        /usr/local/google/home/bcmills/go/src/internal/poll/fd_poll_runtime.go:85 +0x9a
internal/poll.(*pollDesc).waitRead(0xc000428068, 0xc000600001, 0x200, 0x200)
        /usr/local/google/home/bcmills/go/src/internal/poll/fd_poll_runtime.go:90 +0x3d
internal/poll.(*FD).Read(0xc000428050, 0xc000600000, 0x200, 0x200, 0x0, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/internal/poll/fd_unix.go:163 +0x179
os.(*File).read(0xc000400010, 0xc000600000, 0x200, 0x200, 0xc000600000, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/os/file_unix.go:237 +0x4e
os.(*File).Read(0xc000400010, 0xc000600000, 0x200, 0x200, 0xc000284e58, 0x49482c, 0xc000284e60)
        /usr/local/google/home/bcmills/go/src/os/file.go:108 +0x69
bytes.(*Buffer).ReadFrom(0xc0000e6150, 0x879980, 0xc000400010, 0x7f163a726820, 0xc0000e6150, 0xc00049c901)
        /usr/local/google/home/bcmills/go/src/bytes/buffer.go:206 +0xb4
io.copyBuffer(0x879360, 0xc0000e6150, 0x879980, 0xc000400010, 0x0, 0x0, 0x0, 0xc000092280, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/io/io.go:388 +0x303
io.Copy(0x879360, 0xc0000e6150, 0x879980, 0xc000400010, 0x406575, 0xc00006c1e0, 0xc000284fb0)
        /usr/local/google/home/bcmills/go/src/io/io.go:364 +0x5a
os/exec.(*Cmd).writerDescriptor.func1(0xc00006c1e0, 0xc000284fb0)
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:277 +0x4d
os/exec.(*Cmd).Start.func1(0xc000242160, 0xc00014c6a0)
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:398 +0x27
created by os/exec.(*Cmd).Start
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:397 +0x58c

goroutine 23 [IO wait]:
internal/poll.runtime_pollWait(0x7f163a779c30, 0x72, 0xc0002804e8)
        /usr/local/google/home/bcmills/go/src/runtime/netpoll.go:173 +0x66
internal/poll.(*pollDesc).wait(0xc000428108, 0x72, 0xffffffffffffff01, 0x87a3e0, 0xacb508)
        /usr/local/google/home/bcmills/go/src/internal/poll/fd_poll_runtime.go:85 +0x9a
internal/poll.(*pollDesc).waitRead(0xc000428108, 0xc000600201, 0x200, 0x200)
        /usr/local/google/home/bcmills/go/src/internal/poll/fd_poll_runtime.go:90 +0x3d
internal/poll.(*FD).Read(0xc0004280f0, 0xc000600200, 0x200, 0x200, 0x0, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/internal/poll/fd_unix.go:163 +0x179
os.(*File).read(0xc000400028, 0xc000600200, 0x200, 0x200, 0xc000600200, 0x0, 0x0)
        /usr/local/google/home/bcmills/go/src/os/file_unix.go:237 +0x4e
os.(*File).Read(0xc000400028, 0xc000600200, 0x200, 0x200, 0x6d616e222c393332, 0x6d2d6f67223a2265, 0xc000280660)
        /usr/local/google/home/bcmills/go/src/os/file.go:108 +0x69
bytes.(*Buffer).ReadFrom(0xc0000e6000, 0x879980, 0xc000400028, 0x7f163a726820, 0xc0000e6000, 0x2e30737261746101)
        /usr/local/google/home/bcmills/go/src/bytes/buffer.go:206 +0xb4
io.copyBuffer(0x879360, 0xc0000e6000, 0x879980, 0xc000400028, 0x0, 0x0, 0x0, 0x6d6f632e62756874, 0x656c776f7263722f, 0x6c6c6f66222c2279)
        /usr/local/google/home/bcmills/go/src/io/io.go:388 +0x303
io.Copy(0x879360, 0xc0000e6000, 0x879980, 0xc000400028, 0x776f6c6c6f662f79, 0x6f66222c22737265, 0x5f676e69776f6c6c)
        /usr/local/google/home/bcmills/go/src/io/io.go:364 +0x5a
os/exec.(*Cmd).writerDescriptor.func1(0x6c6c6f662f79656c, 0x6f2f7b676e69776f)
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:277 +0x4d
os/exec.(*Cmd).Start.func1(0xc000242160, 0xc00014c740)
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:398 +0x27
created by os/exec.(*Cmd).Start
        /usr/local/google/home/bcmills/go/src/os/exec/exec.go:397 +0x58c

rax    0xca
rbx    0xc0000e8e00
rcx    0x45ec23
rdx    0x0
rdi    0xc0000e8f40
rsi    0x80
rbp    0x7f1635628d50
rsp    0x7f1635628d08
r8     0x0
r9     0x0
r10    0x0
r11    0x286
r12    0x55
r13    0x3
r14    0xc000049f00
r15    0x0
rip    0x45ec21
rflags 0x286
cs     0x33
fs     0x0
gs     0x0
FAIL    golang.org/x/vgo/vendor/cmd/go/internal/modfetch        19.576s

It seems to be hanging in the repo.Stat call within TestCodeRepo.

I see a call to webtest.Hook() at the start of that test and entries for rsc/vgotest1 in testdata/webtest.txt, so I suspect that means that the webtest hook isn't working with command-line git, probably as a result of https://golang.org/cl/107656 (but the test was broken at that change for other reasons) or https://golang.org/cl/107657 (where the test was first broken).

@rsc

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2018

github.com/rsc/vgotest1 is now public.
webtest needs to be deleted.
clearly we are missing some important environment variables to keep git from prompting for passwords.

@bcmills

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2018

I tried removing webtest and ran into a few other failures. Digging in a bit further.


~/src/golang.org/x/vgo/vendor/cmd/go$ go test ./internal/modfetch
--- FAIL: TestCodeRepo (22.05s)
    --- FAIL: TestCodeRepo/github.com_rsc_vgotest1_v2/v2.0.1 (0.52s)
        coderepo_test.go:403: repo.GoMod("v2.0.1"): missing or invalid go.mod
    --- FAIL: TestCodeRepo/github.com_rsc_vgotest1_v2/v2.0.4 (0.56s)
        coderepo_test.go:406: repo.GoMod("v2.0.4"): v2/go.mod has non-.../v2 module path, want "both go.mod and v2/go.mod claim .../v2 module"
    --- FAIL: TestCodeRepo/github.com_rsc_vgotest1_v2/v2.0.5 (0.52s)
        coderepo_test.go:403: repo.GoMod("v2.0.5"): v2/go.mod has non-.../v2 module path
--- FAIL: TestConvertLegacyConfig (33.86s)
    --- FAIL: TestConvertLegacyConfig/github.com_docker_distribution_v0.0.0-20150410205453-85de3967aa93 (0.00s)
        convert_test.go:102: golden:23: invalid module: gopkg.in/yaml.v2 should be v2, not v0 (v0.0.0-20150116202057-bef53efd0c76)
FAIL
FAIL    golang.org/x/vgo/vendor/cmd/go/internal/modfetch        77.442s
@bcmills

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2018

Looks like most of the remaining failures are a subset of #25501.

@gopherbot

This comment has been minimized.

Copy link

commented Jun 6, 2018

Change https://golang.org/cl/116835 mentions this issue: vendor/cmd/go/internal/webtest: remove

@rsc

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2018

https://go-review.googlesource.com/116757 should take care of the git prompts.

gopherbot pushed a commit to golang/vgo that referenced this issue Jun 14, 2018
vendor/cmd/go/internal/modfetch: remove webtest usage in modfetch_test
The webtest hook no longer has any effect on these tests as of CL 107657.
That means the modfetch test is no longer hermetic (it actually talks
to GitHub), but a non-hermetic test is better than no test.

Keep webtest for future use: modfetch still uses web2 in a couple of places.

There are still a few failing tests in modfetch_test.
Those will be fixed in a later change.

Updates golang/go#25742.

Change-Id: Ib50838885fe9dc462ee9b03fcd9e29c1782e8dd6
Reviewed-on: https://go-review.googlesource.com/116835
Reviewed-by: Russ Cox <rsc@golang.org>

@bcmills bcmills closed this Jun 14, 2018

@golang golang locked and limited conversation to collaborators Jun 14, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.