Reminder issue to remove this flag and the respective dead code (when flag is enabled) after release of 1.11. Also, remove the explicit path parameter for cycle tracking (and handle non-package-level cycles).
(The flag was introduced to guard some complex cycle detection code during the freeze so that it's possible to quickly 'undo' those changes if need be.)
The text was updated successfully, but these errors were encountered:
For Go 1.11, cycle tracking of global (package-level) objects was changed
to use a Checker-level object path rather than relying on the explicit
path parameter that is passed around to some (but not all) type-checker
This change now uses the same mechanism for the detection of local
type cycles (local non-type objects cannot create cycles by definition
of the spec).
As a result, local alias cycles are now correctly detected as well
The path parameter that is explicitly passed around to some type-checker
methods is still present and will be removed in a follow-up CL.
- removed useCycleMarking flag and respective dead code
- added a couple more tests
- improved documentation
Run-TryBot: Robert Griesemer <firstname.lastname@example.org>
TryBot-Result: Gobot Gobot <email@example.com>
Reviewed-by: Alan Donovan <firstname.lastname@example.org>