Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
syscall: TOKEN_ALL_ACCESS inconsistency #25775
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
Yes current syscall.TOKEN_ALL_ACCESS is wrong. Current syscall.TOKEN_ALL_ACCESS was correct some long time ago, but was changed. We should change it. I am not sure if we are allowed to change syscall const value.
This const is security related, so it makes it kind of important.
We've decided that it's OK to change values in the syscall package if they are wrong (https://golang.org/doc/go1compat#operating_systems).
Does golang.org/x/sys/windows also need to be fixed?
I checked by writing tests
The result is
I see implementation in
It needs to add