Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: TestBinaryOnlyPackages broken #25784

Closed
bradfitz opened this issue Jun 7, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@bradfitz
Copy link
Member

commented Jun 7, 2018

Test flake in https://storage.googleapis.com/go-build-log/ab26aac8/linux-amd64_5812f616.log

--- FAIL: TestBinaryOnlyPackages (0.02s)
    go_test.go:4232: running testgo [list -f {{.Stale}}:{{.StaleReason}} p1]
    go_test.go:4232: standard output:
    go_test.go:4232: true:missing or invalid binary-only package
        
    go_test.go:4232: standard error:
    go_test.go:4232: go build p1: missing or invalid binary-only package
        
    go_test.go:4232: go [list -f {{.Stale}}:{{.StaleReason}} p1] failed unexpectedly: exit status 1
FAIL
FAIL	cmd/go	106.462s

Failed on one trybot but passed on all the rest, and passed locally.

I didn't investigate.

@bradfitz bradfitz added this to the Go1.11 milestone Jun 7, 2018

@bradfitz bradfitz changed the title cmd/go: TestBinaryOnlyPackages flake cmd/go: TestBinaryOnlyPackages broken Jun 7, 2018

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2018

Nevermind, that's a real failure just introduced at tip, showing across https://build.golang.org/.

It's a non-short test that's run on a number of builders.

@rsc, can you fix?

@bradfitz bradfitz added the Soon label Jun 7, 2018

@bcmills

This comment has been minimized.

Copy link
Member

commented Jun 7, 2018

git bisect confirms that it broke at https://golang.org/cl/108156.

@gopherbot

This comment has been minimized.

Copy link

commented Jun 7, 2018

Change https://golang.org/cl/117075 mentions this issue: cmd/go: skip TestBinaryOnlyPackages until it's fixed

gopherbot pushed a commit that referenced this issue Jun 7, 2018

cmd/go: skip TestBinaryOnlyPackages until it's fixed
Updates #25784

Change-Id: I638eab82b026d3df89da532b5cc3f5c06b02d6c8
Reviewed-on: https://go-review.googlesource.com/117075
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot

This comment has been minimized.

Copy link

commented Jun 7, 2018

Change https://golang.org/cl/117036 mentions this issue: cmd/go: restore "go list" exit code for missing binary packages

@bcmills bcmills removed the help wanted label Jun 7, 2018

@bradfitz bradfitz closed this in 8cf579a Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.