Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/cover: TestCoverHTML failing on Plan 9 #25795

Closed
0intro opened this issue Jun 8, 2018 · 1 comment
Closed

cmd/cover: TestCoverHTML failing on Plan 9 #25795

0intro opened this issue Jun 8, 2018 · 1 comment
Assignees
Milestone

Comments

@0intro
Copy link
Member

@0intro 0intro commented Jun 8, 2018

CL 116975 added TestCoverHTML. This test is failing on Plan 9, because the GNU diff tool is called ape/diff and not diff on Plan 9.

Usage: diff [-abcefmnrw] file1 ... file2
--- FAIL: TestCoverHTML (3.64s)
    cover_test.go:315: exit status: 'diff 6247: error'
FAIL
FAIL	cmd/cover	7.169s

See https://build.golang.org/log/82e588e77c0492cdcd1622330b6c66a72f5d625b

@0intro 0intro added the OS-Plan9 label Jun 8, 2018
@0intro 0intro added this to the Go1.11 milestone Jun 8, 2018
@0intro 0intro self-assigned this Jun 8, 2018
@gopherbot
Copy link

@gopherbot gopherbot commented Jun 8, 2018

Change https://golang.org/cl/117415 mentions this issue: cmd/cover: fix TestCoverHTML on Plan 9

@gopherbot gopherbot closed this in abeac09 Jun 8, 2018
@golang golang locked and limited conversation to collaborators Jun 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.