Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: freebsd-amd64 sendfile implementation is broken. #25809

Closed
alexbrainman opened this issue Jun 10, 2018 · 6 comments

Comments

Assignees
No one assigned
Labels
NeedsInvestigation release-blocker
Projects
None yet
Milestone
  Go1.11
4 participants
@alexbrainman @gopherbot @bradfitz @tklauser
@alexbrainman
Copy link
Member

commented Jun 10, 2018

I was trying to come up with a variation of TestSendfile to reproduce issue #25722 on our builder, and I end-up with

https://go-review.googlesource.com/c/go/+/117655/2

that fails on freebsd-amd64-11_1 builder with

--- FAIL: TestSendfile (0.00s)
sendfile_test.go:74: have="ProProPro", but want="Produced "
FAIL

I could be wrong about that test, but all other builders are OK with it. So I suspect that freebsd-amd64 sendfile implementation is broken.

Leaving for others to decide.

Alex
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 11, 2018

Change https://golang.org/cl/117775 mentions this issue: net: add TestSendfileParts

@bradfitz bradfitz added NeedsInvestigation release-blocker labels Jun 11, 2018

@bradfitz bradfitz added this to the Go1.11 milestone Jun 11, 2018

@bradfitz

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jun 11, 2018

/cc @ianlancetaylor

gopherbot pushed a commit that referenced this issue Jun 11, 2018

@alexbrainman
net: add TestSendfileParts 
Add test for freebsd issue #25809.

This test also fails on my Windows 10 Version 1803.
My hope is that adding new test will break one of our builders.

Updates #25722
Updates #25809

Change-Id: Ia103bc708b8fa3b9af57613acc44893f90b3fa18
Reviewed-on: https://go-review.googlesource.com/117775
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
679690f
@tklauser

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jun 11, 2018

It also seems to be broken (probably in the same way) on dragonfly/amd64: https://build.golang.org/log/ee2bc4ad04e72093b84fbf7f2397f13b4d98e5ed
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 11, 2018

Change https://golang.org/cl/117698 mentions this issue: net: skip TestSendfileParts on dragonfly
@alexbrainman

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jun 11, 2018

And solaris builder is broken too

https://build.golang.org/log/170fc01900ba1c5c58d0a1caa8d1b3b0c708518f

Alex

gopherbot pushed a commit that referenced this issue Jun 11, 2018

@tklauser
net: skip TestSendfileParts on dragonfly and solaris 
Skip it like on freebsd until there is proper a fix for #25809

Updates #25809

Change-Id: Id53c433aee75f2a992ab6a8d58d98fd1f8a6c1c6
Reviewed-on: https://go-review.googlesource.com/117698
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
40fc4bb
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 11, 2018

Change https://golang.org/cl/117895 mentions this issue: net: update file read position after sendfile syscall

@gopherbot gopherbot closed this in 29b631e Jun 12, 2018

tmm1 added a commit to fancybits/go that referenced this issue Sep 17, 2018

@tklauser @tmm1
net: update file read position after sendfile syscall 
On dragonfly, freebsd and solaris the sendfile syscall does not update
the read position of the source fd. Update it after sendfile so
successive calls start at the correct position.

Fixes golang#25809

Change-Id: Iaac79f89704b75b8038d4bb60eaf793a262cdd8f
Reviewed-on: https://go-review.googlesource.com/117895
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
43fe072

tmm1 added a commit to fancybits/go that referenced this issue Sep 17, 2018

@alexbrainman @tmm1
net: add TestSendfileParts 
Add test for freebsd issue golang#25809.

This test also fails on my Windows 10 Version 1803.
My hope is that adding new test will break one of our builders.

Updates golang#25722
Updates golang#25809

Change-Id: Ia103bc708b8fa3b9af57613acc44893f90b3fa18
Reviewed-on: https://go-review.googlesource.com/117775
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
cf9404a

tmm1 added a commit to fancybits/go that referenced this issue Sep 17, 2018

@tklauser @tmm1
net: skip TestSendfileParts on dragonfly and solaris 
Skip it like on freebsd until there is proper a fix for golang#25809

Updates golang#25809

Change-Id: Id53c433aee75f2a992ab6a8d58d98fd1f8a6c1c6
Reviewed-on: https://go-review.googlesource.com/117698
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
5bee8a2

tmm1 added a commit to fancybits/go that referenced this issue Sep 17, 2018

@tklauser @tmm1
net: update file read position after sendfile syscall 
On dragonfly, freebsd and solaris the sendfile syscall does not update
the read position of the source fd. Update it after sendfile so
successive calls start at the correct position.

Fixes golang#25809

Change-Id: Iaac79f89704b75b8038d4bb60eaf793a262cdd8f
Reviewed-on: https://go-review.googlesource.com/117895
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
311267c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.