Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upnet: freebsd-amd64 sendfile implementation is broken. #25809
Closed
Milestone
Comments
This comment has been minimized.
This comment has been minimized.
|
Change https://golang.org/cl/117775 mentions this issue: |
This comment has been minimized.
This comment has been minimized.
|
/cc @ianlancetaylor |
gopherbot
pushed a commit
that referenced
this issue
Jun 11, 2018
Add test for freebsd issue #25809. This test also fails on my Windows 10 Version 1803. My hope is that adding new test will break one of our builders. Updates #25722 Updates #25809 Change-Id: Ia103bc708b8fa3b9af57613acc44893f90b3fa18 Reviewed-on: https://go-review.googlesource.com/117775 Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This comment has been minimized.
This comment has been minimized.
|
It also seems to be broken (probably in the same way) on dragonfly/amd64: https://build.golang.org/log/ee2bc4ad04e72093b84fbf7f2397f13b4d98e5ed |
This comment has been minimized.
This comment has been minimized.
|
Change https://golang.org/cl/117698 mentions this issue: |
This comment has been minimized.
This comment has been minimized.
|
And solaris builder is broken too https://build.golang.org/log/170fc01900ba1c5c58d0a1caa8d1b3b0c708518f Alex |
gopherbot
pushed a commit
that referenced
this issue
Jun 11, 2018
Skip it like on freebsd until there is proper a fix for #25809 Updates #25809 Change-Id: Id53c433aee75f2a992ab6a8d58d98fd1f8a6c1c6 Reviewed-on: https://go-review.googlesource.com/117698 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
This comment has been minimized.
This comment has been minimized.
|
Change https://golang.org/cl/117895 mentions this issue: |
tmm1
added a commit
to fancybits/go
that referenced
this issue
Sep 17, 2018
On dragonfly, freebsd and solaris the sendfile syscall does not update the read position of the source fd. Update it after sendfile so successive calls start at the correct position. Fixes golang#25809 Change-Id: Iaac79f89704b75b8038d4bb60eaf793a262cdd8f Reviewed-on: https://go-review.googlesource.com/117895 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
tmm1
added a commit
to fancybits/go
that referenced
this issue
Sep 17, 2018
Add test for freebsd issue golang#25809. This test also fails on my Windows 10 Version 1803. My hope is that adding new test will break one of our builders. Updates golang#25722 Updates golang#25809 Change-Id: Ia103bc708b8fa3b9af57613acc44893f90b3fa18 Reviewed-on: https://go-review.googlesource.com/117775 Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
tmm1
added a commit
to fancybits/go
that referenced
this issue
Sep 17, 2018
Skip it like on freebsd until there is proper a fix for golang#25809 Updates golang#25809 Change-Id: Id53c433aee75f2a992ab6a8d58d98fd1f8a6c1c6 Reviewed-on: https://go-review.googlesource.com/117698 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
tmm1
added a commit
to fancybits/go
that referenced
this issue
Sep 17, 2018
On dragonfly, freebsd and solaris the sendfile syscall does not update the read position of the source fd. Update it after sendfile so successive calls start at the correct position. Fixes golang#25809 Change-Id: Iaac79f89704b75b8038d4bb60eaf793a262cdd8f Reviewed-on: https://go-review.googlesource.com/117895 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I was trying to come up with a variation of TestSendfile to reproduce issue #25722 on our builder, and I end-up with
https://go-review.googlesource.com/c/go/+/117655/2
that fails on freebsd-amd64-11_1 builder with
--- FAIL: TestSendfile (0.00s)
sendfile_test.go:74: have="ProProPro", but want="Produced "
FAIL
I could be wrong about that test, but all other builders are OK with it. So I suspect that freebsd-amd64 sendfile implementation is broken.
Leaving for others to decide.
Alex