Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/vet: should not complain about format %q used with []string #25869

Closed
bradfitz opened this issue Jun 13, 2018 · 3 comments
Closed

cmd/vet: should not complain about format %q used with []string #25869

bradfitz opened this issue Jun 13, 2018 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation
Milestone
Unplanned

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Jun 13, 2018

In https://go-review.googlesource.com/c/tools/+/118557 @griesemer is adjusting valid code just to appease vet.

I suspect that vet is wrong here and it should permit %q with []string.

/cc @robpike
@andybons

This comment has been minimized.

Sign in to view
Copy link
Member

@andybons andybons commented Jun 13, 2018

@alandonovan
@andybons andybons added this to the Unplanned milestone Jun 13, 2018
@griesemer

This comment has been minimized.

Sign in to view
Copy link
Contributor

@griesemer griesemer commented Jun 13, 2018

Minor correction: The argument is []interface{} not []string.
@bradfitz

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

@bradfitz bradfitz commented Jun 13, 2018

Ah, never mind then.

(Too) early morning here. Can't read apparently.
@bradfitz bradfitz closed this Jun 13, 2018
@golang golang locked and limited conversation to collaborators Jun 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation
Projects
None yet
Milestone
  Unplanned
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@bradfitz @andybons @griesemer @gopherbot
You can’t perform that action at this time.