New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: linux-amd64-longtest builder failing #25886

Open
mvdan opened this Issue Jun 14, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@mvdan
Member

mvdan commented Jun 14, 2018

For example: https://build.golang.org/log/9b5c6ae2c5be87e49c9893e9ea6dcc2aa6198200

The builder has been consistently broken for this and other reasons since mid-May, so it's hard to pinpoint when this failure started happening. I tried looking for an existing issue about this, but couldn't find any.

If I run go test -v runtime on my laptop, I get the result:

ok      runtime 171.977s

Perhaps the three-minute timeout per package is too low for the runtime package, seeing as how my run barely fit under 180s. Or perhaps some of the long or expensive tests should be made faster.

/cc @aclements @ianlancetaylor @bradfitz

Tangential question - should this be labelled Testing or Builders? Perhaps the label descriptions could be clarified.

@mvdan mvdan added this to the Go1.11 milestone Jun 14, 2018

@ALTree

This comment has been minimized.

Member

ALTree commented Jun 14, 2018

I bumped the timeout to 6 minutes in CL 115016.

Either I did it wrong or it's not deployed yet.

@ALTree

This comment has been minimized.

Member

ALTree commented Jun 14, 2018

p.s. I thinks this should be labeled "builders".

@mvdan

This comment has been minimized.

Member

mvdan commented Jun 14, 2018

Ah, I forgot to remove the is:open filter from my issue search. It didn't occur to me that the issue was already closed. I naively assumed that it couldn't have been, since the problem is still present :)

Then yes, this seems like it should be labelled Builders. Do you want to keep this issue open to track the deployment/debugging of your fix?

@mvdan mvdan added Builders and removed Testing labels Jun 14, 2018

@mvdan mvdan changed the title from runtime: tests consistently timing out after 3m on linux-amd64-longtest to x/build: linux-amd64-longtest still timing out on the runtime tests Jun 14, 2018

@ALTree

This comment has been minimized.

Member

ALTree commented Jun 14, 2018

Do you want to keep this issue open to track the deployment/debugging of your fix?

I guess we could do this to avoid someone else opening another one : ) Once the version with the new time limit is deployed we can close.

@ianlancetaylor ianlancetaylor modified the milestones: Go1.11, Go1.12 Jun 29, 2018

@bradfitz bradfitz changed the title from x/build: linux-amd64-longtest still timing out on the runtime tests to runtime: linux-amd64-longtest builder failing Aug 29, 2018

@mvdan

This comment has been minimized.

Member

mvdan commented Sep 28, 2018

We're closer - now it only fails most of the time. When it does fail, it seems like the usual culprit is:

##### GOMAXPROCS=2 runtime -cpu=1,2,4 -quick
panic: test timed out after 10m0s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment