Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vgo: "file not found" when fetching a repo without README, .gitignore, .gitattributes, or go.mod #25895

Closed
Gobd opened this issue Jun 14, 2018 · 4 comments

Comments

@Gobd
Copy link

commented Jun 14, 2018

What version of Go are you using (go version)?

go version go1.10.3 darwin/amd64

Does this issue reproduce with the latest release?

yes

What did you do?

vgo build with a dependency that has none of the files listed here and you get a "file not found" error. This error should be more descriptive or this requirement to have one of these files should be removed

@gopherbot gopherbot added this to the vgo milestone Jun 14, 2018

@oiooj oiooj added the NeedsDecision label Jun 14, 2018

@bcmills

This comment has been minimized.

Copy link
Member

commented Jun 15, 2018

Could you give a more complete example? What vgo command did you run, and what was the complete (less-than-useful) output?

(CC @kardianos, who has been working on improving error reporting.)

@Gobd

This comment has been minimized.

Copy link
Author

commented Jun 18, 2018

vgo get project
vgo get project: file not found
vgo: import "project" [/Users/user/code/src/project]: no Go source files

This is when you vgo get a project that only has *.go files, nothing else. There are clearly go source files, and I can go get the project just fine, also works with dep. The user has no indication that the fix to this problem is to add a file from the link the original issue.

@bcmills bcmills changed the title x/vgo: Make "file not found" error more useful x/vgo: "file not found" when fetching a repo without README, .gitignore, .gitattributes, or go.mod. Jun 18, 2018

@bcmills bcmills changed the title x/vgo: "file not found" when fetching a repo without README, .gitignore, .gitattributes, or go.mod. x/vgo: "file not found" when fetching a repo without README, .gitignore, .gitattributes, or go.mod Jun 18, 2018

@bcmills

This comment has been minimized.

Copy link
Member

commented Jun 18, 2018

Thanks for the clarification. Since users can't add a file to a repo they don't own in general, we should probably fall back to a slower path, rather than failing with instructions that the user may not be able to follow.

@bcmills bcmills removed the WaitingForInfo label Jun 18, 2018

@rsc

This comment has been minimized.

Copy link
Contributor

commented Jul 6, 2018

That code is gone.

@rsc rsc closed this Jul 6, 2018

@golang golang locked and limited conversation to collaborators Jul 6, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.