Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: Darwin build fails with "unknown load command" [1.10 backport] #25912

Closed
gopherbot opened this issue Jun 15, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@gopherbot
Copy link

commented Jun 15, 2018

@mistydemeo requested issue #25908 to be considered for backport to the next 1.10 minor release.

@gopherbot please consider this for backport to 1.10, it's a regression

@gopherbot

This comment has been minimized.

Copy link
Author

commented Jun 15, 2018

Change https://golang.org/cl/119215 mentions this issue: [release-branch.go1.10] ld/macho: add all missing load commands

@gopherbot

This comment has been minimized.

Copy link
Author

commented Jun 15, 2018

Closed by merging 3d59583 to release-branch.go1.10.

@gopherbot gopherbot closed this Jun 15, 2018

gopherbot pushed a commit that referenced this issue Jun 15, 2018

[release-branch.go1.10] ld/macho: add all missing load commands
The ld/macho code currently understands a subset of the mach-o load
commands. I've encountered one of these in the wild in a Go-produced
binary, which tripped up the Go linker because its switch statement
expects its list of load commands to be exhaustive; the rest I've
added for the sake of completion.

The ruby-macho library is a good non-Darwin header resource for these:
https://github.com/homebrew/ruby-macho

Fixes #25912

Change-Id: Ib54c065d27e87d8726a9870df05a2bae24828b98
GitHub-Last-Rev: 655e3f4
GitHub-Pull-Request: #25906
Reviewed-on: https://go-review.googlesource.com/119115
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit 1a92cdb)
Reviewed-on: https://go-review.googlesource.com/119215
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.