Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upcmd/link: Darwin build fails with "unknown load command" [1.10 backport] #25912
Labels
Milestone
Comments
This comment has been minimized.
This comment has been minimized.
|
Change https://golang.org/cl/119215 mentions this issue: |
This comment has been minimized.
This comment has been minimized.
|
Closed by merging 3d59583 to release-branch.go1.10. |
gopherbot
pushed a commit
that referenced
this issue
Jun 15, 2018
The ld/macho code currently understands a subset of the mach-o load commands. I've encountered one of these in the wild in a Go-produced binary, which tripped up the Go linker because its switch statement expects its list of load commands to be exhaustive; the rest I've added for the sake of completion. The ruby-macho library is a good non-Darwin header resource for these: https://github.com/homebrew/ruby-macho Fixes #25912 Change-Id: Ib54c065d27e87d8726a9870df05a2bae24828b98 GitHub-Last-Rev: 655e3f4 GitHub-Pull-Request: #25906 Reviewed-on: https://go-review.googlesource.com/119115 Reviewed-by: Ian Lance Taylor <iant@golang.org> (cherry picked from commit 1a92cdb) Reviewed-on: https://go-review.googlesource.com/119215 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
@mistydemeo requested issue #25908 to be considered for backport to the next 1.10 minor release.