Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/link: test failure in TestLldbPython from commit 594eae5 onward #25925
What version of Go are you using (
We basically have three options: roll back compression, tell everyone to update lldb, or skip the test. I don't want to roll back compression. Updating lldb is going to be a hassle -- I'm not even sure if that change has hit a release yet. So I'm inclined to skip the test and we can re-enable it once lldb has released the change @aarzilli linked to. Or maybe make it a long test so that people are less likely to run it?
lldb doesn't support compressed DWARF, so right now we're just always skipping the lldb test. This CL makes the test run again by disabling compressed DWARF just for this test. Updates #25925. Change-Id: Ib9ddc442305fe6d37060d48f36bc4458b6fd8c86 Reviewed-on: https://go-review.googlesource.com/124385 Run-TryBot: Austin Clements <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-by: Brad Fitzpatrick <firstname.lastname@example.org>
This reverts commit c993002. The original CL skipped the lldb test if it couldn't read compressed DWARF, but lldb can never read compressed DWARF, so this effectively disabled this test unconditionally. The previous commit disabled DWARF compression for this test, so the test now works on its own merits again. This CL reverts the change to skip the test so we don't simply mask lldb failures. Updates #25925. Change-Id: I3e1c787b658257b542c3c70807065dde9cfe05ee Reviewed-on: https://go-review.googlesource.com/124386 Run-TryBot: Austin Clements <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org> Reviewed-by: Brad Fitzpatrick <email@example.com>
Until we figure out how to deal with gdb on Darwin (doesn't read compressed DWARF from binaries), avoid compressing DWARF in that case so that the test will still yield meaningful results. This is also reported to be a problem for Windows. Problem also exists for lldb, but this test doesn't check lldb. Updates #25925 Change-Id: I85c0e5db75f3329957290500626a3ac7f078f608 Reviewed-on: https://go-review.googlesource.com/124712 Run-TryBot: David Chase <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-by: Heschi Kreinick <firstname.lastname@example.org>