Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/pprof: upgrade "go tool pprof" to a version that can render flame graphs #25935

Closed
dweitzman opened this issue Jun 18, 2018 · 1 comment
Closed

Comments

@dweitzman
Copy link

@dweitzman dweitzman commented Jun 18, 2018

The vendored version of pprof in golang is more than a year old.

Flame graph support has been added to pprof since them, so it seems worthwhile to update the dependency.

@ALTree
Copy link
Member

@ALTree ALTree commented Jun 18, 2018

Thanks for the report.

The vendored version of pprof in golang is more than a year old.

I assume you're talking about the version vendored in go1.10.

Current tip (to be 1.11) includes upstream revision 1ddc9e21ddc9e2, it was vendored recently (see https://go-review.googlesource.com/c/go/+/115295); so for flame graph support there's nothing else left to do except wait for the next go release (go1.11).

Closing here, since the work has already been done.

@ALTree ALTree closed this Jun 18, 2018
@ALTree ALTree changed the title Upgrade "go tool pprof" to a version that can render flame graphs cmd/pprof: upgrade "go tool pprof" to a version that can render flame graphs Jun 18, 2018
@golang golang locked and limited conversation to collaborators Jun 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.