Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: add misc-compile-mobile TryBots for Android/iOS #25963

Open
FiloSottile opened this issue Jun 19, 2018 · 10 comments
Open

x/build: add misc-compile-mobile TryBots for Android/iOS #25963

FiloSottile opened this issue Jun 19, 2018 · 10 comments

Comments

@FiloSottile
Copy link
Member

@FiloSottile FiloSottile commented Jun 19, 2018

https://storage.googleapis.com/go-build-log/21200cf2/misc-compile-mobile_0b3b3144.log

/workdir/go/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
/tmp/go-link-391904482/go.o:(.data+0x0): undefined reference to `x_cgo_init'
/tmp/go-link-391904482/go.o:(.data+0x4): undefined reference to `x_cgo_notify_runtime_init_done'
/tmp/go-link-391904482/go.o:(.data+0x8): undefined reference to `x_cgo_thread_start'
/tmp/go-link-391904482/go.o:(.data+0x14): undefined reference to `x_cgo_setenv'
/tmp/go-link-391904482/go.o:(.data+0x18): undefined reference to `x_cgo_unsetenv'
/tmp/go-link-391904482/go.o:(.data+0x1c): undefined reference to `_cgo_yield'
collect2: error: ld returned 1 exit status

If this is caused by my change (https://go-review.googlesource.com/c/go/+/109697) I can't see it.

/cc @bradfitz

@gopherbot gopherbot added this to the Unreleased milestone Jun 19, 2018
@gopherbot gopherbot added the Builders label Jun 19, 2018
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jun 19, 2018

Change https://golang.org/cl/119856 mentions this issue: dashboard: remove mobile misc-compile trybots

@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Jun 19, 2018

I guess those never worked.

We're probably missing some stuff or environment in our Dockerfile. Missing Android toolchain, etc. The Darwin one may not be possible, or we might need to do it from a Mac VM, not Docker.

/cc @eliasnaur.

gopherbot pushed a commit to golang/build that referenced this issue Jun 19, 2018
I guess they never worked.

Updates golang/go#25963

Change-Id: I1409a704670032410c3c6b87cbbb876fc96dfb22
Reviewed-on: https://go-review.googlesource.com/119856
Reviewed-by: Filippo Valsorda <filippo@golang.org>
@eliasnaur

This comment has been minimized.

Copy link
Contributor

@eliasnaur eliasnaur commented Jun 19, 2018

What's to do here? I think I'm missing context.

@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Jun 19, 2018

We'd like a trybot that at least compiles most things (runs make.bash) for the Android & iOS builds, even if we don't use a real device or simulator/emulator and don't actually run any tests. We have such trybots for all other ports, but not mobile.

@eliasnaur

This comment has been minimized.

Copy link
Contributor

@eliasnaur eliasnaur commented Jun 19, 2018

Ok. Is the Dockerfile from

#23824 (comment)

of any help for Android? For iOS I believe you need macOS with Xcode installed.

@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Aug 3, 2018

/cc @dmitshur

@bradfitz bradfitz changed the title x/build: misc-compile-mobile TryBot broken x/build: add misc-compile-mobile TryBots for Android/iOS Aug 29, 2018
@eliasnaur

This comment has been minimized.

Copy link
Contributor

@eliasnaur eliasnaur commented Feb 24, 2019

I believe the Android part is being done as part of #23824.

@mcandre

This comment has been minimized.

Copy link

@mcandre mcandre commented Jun 30, 2019

Seems strange for Go to claim to offer certain os, arch pairs that it can't actually build without an external toolchain setup

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Jun 30, 2019

@mcandre What do you suggest we do? It doesn't seem to make sense to say that we don't support these systems.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 15, 2019

Change https://golang.org/cl/207377 mentions this issue: dashboard: remove misc-compile-android builder

gopherbot pushed a commit to golang/build that referenced this issue Nov 15, 2019
Fixes golang/go#35596
Updates golang/go#25963

Change-Id: I9db5154dcdd0e432dfe2d0d8697fedabed50a7ed
Reviewed-on: https://go-review.googlesource.com/c/build/+/207377
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.