Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: add misc-compile-mobile TryBots for Android/iOS #25963

Open
FiloSottile opened this issue Jun 19, 2018 · 12 comments
Open

x/build: add misc-compile-mobile TryBots for Android/iOS #25963

FiloSottile opened this issue Jun 19, 2018 · 12 comments
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. new-builder
Milestone

Comments

@FiloSottile
Copy link
Contributor

https://storage.googleapis.com/go-build-log/21200cf2/misc-compile-mobile_0b3b3144.log

/workdir/go/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
/tmp/go-link-391904482/go.o:(.data+0x0): undefined reference to `x_cgo_init'
/tmp/go-link-391904482/go.o:(.data+0x4): undefined reference to `x_cgo_notify_runtime_init_done'
/tmp/go-link-391904482/go.o:(.data+0x8): undefined reference to `x_cgo_thread_start'
/tmp/go-link-391904482/go.o:(.data+0x14): undefined reference to `x_cgo_setenv'
/tmp/go-link-391904482/go.o:(.data+0x18): undefined reference to `x_cgo_unsetenv'
/tmp/go-link-391904482/go.o:(.data+0x1c): undefined reference to `_cgo_yield'
collect2: error: ld returned 1 exit status

If this is caused by my change (https://go-review.googlesource.com/c/go/+/109697) I can't see it.

/cc @bradfitz

@gopherbot gopherbot added this to the Unreleased milestone Jun 19, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jun 19, 2018
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/119856 mentions this issue: dashboard: remove mobile misc-compile trybots

@bradfitz
Copy link
Contributor

I guess those never worked.

We're probably missing some stuff or environment in our Dockerfile. Missing Android toolchain, etc. The Darwin one may not be possible, or we might need to do it from a Mac VM, not Docker.

/cc @eliasnaur.

gopherbot pushed a commit to golang/build that referenced this issue Jun 19, 2018
I guess they never worked.

Updates golang/go#25963

Change-Id: I1409a704670032410c3c6b87cbbb876fc96dfb22
Reviewed-on: https://go-review.googlesource.com/119856
Reviewed-by: Filippo Valsorda <filippo@golang.org>
@eliasnaur
Copy link
Contributor

What's to do here? I think I'm missing context.

@bradfitz
Copy link
Contributor

We'd like a trybot that at least compiles most things (runs make.bash) for the Android & iOS builds, even if we don't use a real device or simulator/emulator and don't actually run any tests. We have such trybots for all other ports, but not mobile.

@eliasnaur
Copy link
Contributor

Ok. Is the Dockerfile from

#23824 (comment)

of any help for Android? For iOS I believe you need macOS with Xcode installed.

@bradfitz
Copy link
Contributor

bradfitz commented Aug 3, 2018

/cc @dmitshur

@bradfitz bradfitz changed the title x/build: misc-compile-mobile TryBot broken x/build: add misc-compile-mobile TryBots for Android/iOS Aug 29, 2018
@eliasnaur
Copy link
Contributor

I believe the Android part is being done as part of #23824.

@mcandre
Copy link

mcandre commented Jun 30, 2019

Seems strange for Go to claim to offer certain os, arch pairs that it can't actually build without an external toolchain setup

@ianlancetaylor
Copy link
Contributor

@mcandre What do you suggest we do? It doesn't seem to make sense to say that we don't support these systems.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/207377 mentions this issue: dashboard: remove misc-compile-android builder

gopherbot pushed a commit to golang/build that referenced this issue Nov 15, 2019
Fixes golang/go#35596
Updates golang/go#25963

Change-Id: I9db5154dcdd0e432dfe2d0d8697fedabed50a7ed
Reviewed-on: https://go-review.googlesource.com/c/build/+/207377
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/258057 mentions this issue: dashboard: remove misc-compile-ios builder

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/257962 mentions this issue: src/buildall.bash: remove mobile filter

gopherbot pushed a commit to golang/build that referenced this issue Sep 28, 2020
Since sending CL 257617, I've learned that iOS was never a supported
target for misc-compile. It was always filtered out unconditionally
in GOROOT/src/buildall.bash, and the comment suggesting that we test
iOS targets was inaccurate.

Remove the naive misc-compile-ios builder since it's not expected to
start working soon, and update misc-builder architecture filtering
code and comments to match the current reality better.

After this change, it will be viable to remove mobile target filtering
from GOROOT/src/buildall.bash. If that's done, then x/build/dashboard
will become a centralized place for all misc-builder target selection.

Ignore darwin-arm in TestTryBotsCompileAllPorts so the test doesn't
fail when executed with Go 1.14. Not having that builder is intended.

For golang/go#41610.
Updates golang/go#25963.

Change-Id: Ic6f5dc95edb67f8e6ebc0a77979e55eb0cc325cb
Reviewed-on: https://go-review.googlesource.com/c/build/+/258057
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. new-builder
Projects
None yet
Development

No branches or pull requests

7 participants