Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/sys/windows: add missing file attributes #25979

Closed
Kropekk opened this issue Jun 20, 2018 · 2 comments
Closed

x/sys/windows: add missing file attributes #25979

Kropekk opened this issue Jun 20, 2018 · 2 comments

Comments

@Kropekk
Copy link

@Kropekk Kropekk commented Jun 20, 2018

In syscall library for Windows (version for amd64 architecture ) not all file attributes are present.

There are some constants already defined (FILE_ATTRIBUTE_*), but I would expect to see all of them or at least all applicable to syscall.SetFileAttributes(...) function (msdn docs for underlying function).

On the other hand, the remaining ones would be helpful in parsing syscall.GetFileAttributes(...) return value.

Summing up, I think that all FILE_ATTRIBUTE_* constants should be present in Windows-OS syscall library.

(BTW, I wanted to attach some labels to my issue, but I think it's not possible for a newcomer)

@gopherbot gopherbot added this to the Proposal milestone Jun 20, 2018
@gopherbot gopherbot added the Proposal label Jun 20, 2018
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Jun 20, 2018

We aren't going to add any more constants to the syscall package. They should be added to the golang.org/x/sys/windows package instead. See https://docs.google.com/document/d/1QXzI9I1pOfZPujQzxhyRy6EeHYTQitKKjHfpq0zpxZs/edit#heading=h.5nqylt8x3hka .

@ianlancetaylor ianlancetaylor changed the title proposal: syscall (Windows OS): Missing file attributes in syscall library for Windows OS x/sys/windows: add missing file attributes Jun 20, 2018
@ianlancetaylor ianlancetaylor modified the milestones: Proposal, Unreleased Jun 20, 2018
@gopherbot
Copy link

@gopherbot gopherbot commented Jul 6, 2018

Change https://golang.org/cl/122236 mentions this issue: windows: add missing file attributes

@golang golang locked and limited conversation to collaborators Jul 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.