Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
cmd/dist: child process prints to log after make.bash has exited #25981
Notice the $ sign appearing in the middle of the output. This indicates that make.bash exited and the shell printed its prompt, but some child process of make.bash is still printing log output. make.bash should wait for its children to exit before exiting itself.
@ianlancetaylor - Looked into this. The
If I add a simple
Or maybe I missed something altogether, please do let me know if that is the case.
Hmmm, this does seem kind of complicated as it seems easy to get into a deadlock situation, in which
In some sense code that is running in a goroutine, like