x/crypto/openpgp: add FlagsAuthenticate, FlagsGroupKey and FlagsSplitKey support to packet.Signature

[scruplelesswizard]

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.10.3 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

GOHOSTARCH="amd64"
GOHOSTOS="darwin"

What did you do?

Attempted to set authentication flag (0x20) in a packet.Signature

packet.Signature{
  FlagsValid:        true,
  FlagsAuthenticate: true,
}

What did you expect to see?

No error

What did you see instead?

Error: unknown field 'FlagsAuthenticate' in struct literal of type packet.Signature

[scruplelesswizard]

Flag is defined in RFC 4880 Section 5.2.3.21

[scruplelesswizard]

It seems I can't self-assign, but I am working on a patch and will submit via Geritt hopefully today

[scruplelesswizard]

Two additional flags, FlagsGroupKey (0x80) and FlagsSplitKey(0x10) are also missing

[scruplelesswizard]

Relevant Patch: https://go-review.googlesource.com/c/crypto/+/120315

[gopherbot]

Change https://golang.org/cl/120315 mentions this issue: x/crypto/openpgp: add FlagsAuthenticate, FlagsGroupKey and FlagsSplitKey support to packet.Signature

[abarisani]

+1 I'd like to see this implemented as well. Thanks!