Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/openpgp: add FlagsAuthenticate, FlagsGroupKey and FlagsSplitKey support to packet.Signature #25983

Closed
chaosaffe opened this issue Jun 20, 2018 · 7 comments

Comments

@chaosaffe
Copy link

@chaosaffe chaosaffe commented Jun 20, 2018

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.10.3 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

GOHOSTARCH="amd64"
GOHOSTOS="darwin"

What did you do?

Attempted to set authentication flag (0x20) in a packet.Signature

packet.Signature{
  FlagsValid:        true,
  FlagsAuthenticate: true,
}

What did you expect to see?

No error

What did you see instead?

Error: unknown field 'FlagsAuthenticate' in struct literal of type packet.Signature

@chaosaffe
Copy link
Author

@chaosaffe chaosaffe commented Jun 20, 2018

Flag is defined in RFC 4880 Section 5.2.3.21

@chaosaffe chaosaffe changed the title 'golang.org/x/crypto/openpgp/packet' Signature missing Key Flags x/crypto: Signature missing Key Flags Jun 20, 2018
@gopherbot gopherbot added this to the Unreleased milestone Jun 20, 2018
@chaosaffe chaosaffe changed the title x/crypto: Signature missing Key Flags x/crypto: OpenPGP Packet Signature missing Key Flags Jun 20, 2018
@FiloSottile FiloSottile changed the title x/crypto: OpenPGP Packet Signature missing Key Flags x/crypto/openpgp: add FlagsAuthenticate support to packet.Signature Jun 20, 2018
@chaosaffe
Copy link
Author

@chaosaffe chaosaffe commented Jun 21, 2018

It seems I can't self-assign, but I am working on a patch and will submit via Geritt hopefully today

@chaosaffe chaosaffe changed the title x/crypto/openpgp: add FlagsAuthenticate support to packet.Signature x/crypto/openpgp: add FlagsAuthenticate, FlagsGroupKey and FlagsSplitKey support to packet.Signature Jun 21, 2018
@chaosaffe
Copy link
Author

@chaosaffe chaosaffe commented Jun 21, 2018

Two additional flags, FlagsGroupKey (0x80) and FlagsSplitKey(0x10) are also missing

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 27, 2018

Change https://golang.org/cl/120315 mentions this issue: x/crypto/openpgp: add FlagsAuthenticate, FlagsGroupKey and FlagsSplitKey support to packet.Signature

@abarisani
Copy link

@abarisani abarisani commented Feb 18, 2020

+1 I'd like to see this implemented as well. Thanks!

@FiloSottile
Copy link
Contributor

@FiloSottile FiloSottile commented Mar 29, 2021

Per the accepted #44226 proposal and due to lack of maintenance, the golang.org/x/crypto/openpgp package is now frozen and deprecated. No new changes will be accepted except for security fixes. The package will not be removed.

If this is a security issue, please email security@golang.org and we will assess it and provide a fix.

If you're looking for alternatives, consider the crypto/ed25519 package for simple signatures, golang.org/x/mod/sumdb/note for inline signatures, or filippo.io/age for encryption. You can read a summary of OpenPGP issues and alternatives here.

If you are required to interoperate with OpenPGP systems and need a maintained package, we suggest considering one of multiple community forks of golang.org/x/crypto/openpgp. We don't endorse any specific one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants