x/crypto/openpgp: add PreferredKeyServer support to packet.Signature

[scruplelesswizard]

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.10.3 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

GOHOSTARCH="amd64"
GOHOSTOS="darwin"

What did you do?

Attempted to set the Preferred Key Server (subpacket 24) in a packet.Signature

packet.Signature{
  PreferedKeyServer: "hkps://hkps.pool.sks-keyservers.net"
}

What did you expect to see?

No error

What did you see instead?

Error: unknown field 'PreferedKeyServer' in struct literal of type packet.Signature

[scruplelesswizard]

Subpacket is defined in RFC 4880 Section 5.2.3.18

[scruplelesswizard]

Can't self-assign. Am working on a patch and will submit today

[scruplelesswizard]

Relevant Patch: https://go-review.googlesource.com/c/crypto/+/120555

[gopherbot]

Change https://golang.org/cl/120555 mentions this issue: openpgp: add PreferredKeyServer support to packet.Signature

[FiloSottile]

Per the accepted #44226 proposal and due to lack of maintenance, the golang.org/x/crypto/openpgp package is now frozen and deprecated. No new changes will be accepted except for security fixes. The package will not be removed.

If this is a security issue, please email security@golang.org and we will assess it and provide a fix.

If you're looking for alternatives, consider the crypto/ed25519 package for simple signatures, golang.org/x/mod/sumdb/note for inline signatures, or filippo.io/age for encryption. You can read a summary of OpenPGP issues and alternatives here.

If you are required to interoperate with OpenPGP systems and need a maintained package, we suggest considering one of multiple community forks of golang.org/x/crypto/openpgp. We don't endorse any specific one.