Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/poll: broken on js/wasm #26014

Closed
bradfitz opened this issue Jun 22, 2018 · 2 comments
Closed

internal/poll: broken on js/wasm #26014

bradfitz opened this issue Jun 22, 2018 · 2 comments

Comments

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jun 22, 2018

Change https://golang.org/cl/120575 mentions this issue: cmd/dist: skip non-std tests on js/wasm

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jun 22, 2018

Change https://golang.org/cl/120576 mentions this issue: syscall, internal/poll: fix build on js/wasm

gopherbot pushed a commit that referenced this issue Jun 22, 2018
After the std tests, most of the rest of the tests aren't applicable
to js/wasm. (anything with -cpu=>1, cgo, etc)

Skip them all for now. We can incrementally re-enable them over time
as the js/wasm port is fleshed out. But let's get the builder column
black again so we can enable trybots and keep it black.

Updates #26014
Updates #26015
Updates #18892

Change-Id: I8992ed3888f598fa42273ce8646a32d62ce45b1d
Reviewed-on: https://go-review.googlesource.com/120575
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
@gopherbot gopherbot closed this in 3dced51 Jun 22, 2018
@golang golang locked and limited conversation to collaborators Jun 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.