Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: add js/wasm trybot #26015

Closed
bradfitz opened this issue Jun 22, 2018 · 5 comments
Closed

x/build: add js/wasm trybot #26015

bradfitz opened this issue Jun 22, 2018 · 5 comments
Assignees
@bradfitz
Labels
Arch-Wasm Builders FrozenDueToAge NeedsFix Soon
Milestone
Go1.11

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Jun 22, 2018

Add either a just-compile or a sharded testing js/wasm trybot.

Would've prevented #26014.

/cc @ianlancetaylor @neelance @andybons @bcmills @FiloSottile
@bradfitz bradfitz added the Soon label Jun 22, 2018
@bradfitz bradfitz added this to the Go1.11 milestone Jun 22, 2018
@bradfitz bradfitz self-assigned this Jun 22, 2018
@gopherbot gopherbot added the Builders label Jun 22, 2018
@gopherbot
Copy link

@gopherbot gopherbot commented Jun 22, 2018

Change https://golang.org/cl/120575 mentions this issue: cmd/dist: skip non-std tests on js/wasm
gopherbot pushed a commit that referenced this issue Jun 22, 2018
@bradfitz
cmd/dist: skip non-std tests on js/wasm
7d50abf 
After the std tests, most of the rest of the tests aren't applicable
to js/wasm. (anything with -cpu=>1, cgo, etc)

Skip them all for now. We can incrementally re-enable them over time
as the js/wasm port is fleshed out. But let's get the builder column
black again so we can enable trybots and keep it black.

Updates #26014
Updates #26015
Updates #18892

Change-Id: I8992ed3888f598fa42273ce8646a32d62ce45b1d
Reviewed-on: https://go-review.googlesource.com/120575
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
@myitcv
Copy link
Member

@myitcv myitcv commented Jun 25, 2018

@bradfitz - I'm not so familiar with how the builders work, but would it be possible to have Node, Chrome and Firefox installed on the image/setup where the js/wasm tests then run?

Headless tests via Chrome and Firefox at least would likely be a big help.
@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Jun 25, 2018

@myitcv, let's keep this bug about just TryBot-ifying the existing Node-based wasm builder. Creating a new Chrome and/or Firebox-based builder is possible I'm sure, but let's track that elsewhere.
@myitcv myitcv mentioned this issue Jun 25, 2018
Open
@gopherbot
Copy link

@gopherbot gopherbot commented Jun 25, 2018

Change https://golang.org/cl/120775 mentions this issue: dashboard: enable trybots for js/wasm
@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Jun 25, 2018

This is deployed. I'll watch its performance.
@golang golang locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bradfitz bradfitz

Labels
Arch-Wasm Builders FrozenDueToAge NeedsFix Soon
Projects
None yet
Milestone
Go1.11
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@bradfitz @myitcv @gopherbot