Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/dist: enable all js/wasm tests that should pass in dist #26050

Closed
bradfitz opened this issue Jun 25, 2018 · 4 comments
Closed

cmd/dist: enable all js/wasm tests that should pass in dist #26050

bradfitz opened this issue Jun 25, 2018 · 4 comments

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Jun 25, 2018

@neelance, please modify cmd/dist/test.go to enable all tests you expect to pass for js/wasm.

I disabled a bunch of tests in 7d50abf because I needed to finally see some black on the dashboard for the js-wasm column to be able to enable trybots and start catching regressions (like #26014)

/cc @cherrymui

@neelance
Copy link
Member

@neelance neelance commented Jun 25, 2018

I didn't know that you were waiting on this. I'm not currently running the tests this way on my machine. Looking into it now. I need to make sure that env GOOS=js GOARCH=wasm ./bin/go tool dist test passes, right?

@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Jun 25, 2018

Test:

$ GOOS=js GOARCH=wasm ./all.bash

... which ultimately calls dist. But yes, you can test it with go tool dist test too.

Note parts of https://github.com/golang/go/wiki/PortingPolicy mentioning all.bash:

Once those conditions are satisfied, the Go team can accept the port and begin to merge the CLs. Once the CLs are all submitted, all.bash must pass, so that the builder reports "ok" in the dashboard.

Any port started during a release cycle must be finished (all.bash passing, builder reporting "ok") before the corresponding release freeze, or else the code will be removed at the freeze.

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 25, 2018

Change https://golang.org/cl/120796 mentions this issue: cmd/dist: enable more tests on js/wasm

@gopherbot gopherbot closed this in 6d70952 Jun 25, 2018
@neelance
Copy link
Member

@neelance neelance commented Jun 25, 2018

@bradfitz Thanks!

@golang golang locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.