Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: use wrappers for op= map operations #26059

Open
randall77 opened this issue Jun 26, 2018 · 5 comments
Open

runtime: use wrappers for op= map operations #26059

randall77 opened this issue Jun 26, 2018 · 5 comments

Comments

@randall77
Copy link
Contributor

@randall77 randall77 commented Jun 26, 2018

CL 120255 made mapdelete zero the value all the time, to make sure op= map operations work correctly.
Probably we should do wrapper functions for op= operations so we don't need to zero during all map deletes.

@vkuzmin-uber
@martisch

@vkuzmin-uber
Copy link
Contributor

@vkuzmin-uber vkuzmin-uber commented Sep 19, 2018

Looking on it.

@randall77 randall77 assigned randall77 and unassigned martisch and randall77 Sep 19, 2018
@randall77
Copy link
Contributor Author

@randall77 randall77 commented Sep 19, 2018

@vkuzmin-uber : For some reason I can't assign you to this issue. I tried and failed.

@dominikh
Copy link
Member

@dominikh dominikh commented Sep 19, 2018

@randall77 that's what the go-assignees role exists for. Only members of some role in the organization can be assigned issues.

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 3, 2018

Change https://golang.org/cl/139101 mentions this issue: runtime: use wrappers for op= map operations

@vkuzmin-uber
Copy link
Contributor

@vkuzmin-uber vkuzmin-uber commented Oct 3, 2018

Just published change that works. I consider this as a proof of concept and feel free to suggest another design. About "go-assignees role" - please let me know if I can do something to get it.

@aclements aclements removed this from the Go1.12 milestone Jan 8, 2019
@aclements aclements added this to the Go1.13 milestone Jan 8, 2019
@randall77 randall77 removed this from the Go1.13 milestone Jun 3, 2019
@randall77 randall77 added this to the Go1.14 milestone Jun 3, 2019
@rsc rsc removed this from the Go1.14 milestone Oct 9, 2019
@rsc rsc added this to the Backlog milestone Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants