Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: add subversion zip support #26092

Closed
rsc opened this issue Jun 27, 2018 · 5 comments
Closed

cmd/go: add subversion zip support #26092

rsc opened this issue Jun 27, 2018 · 5 comments
Assignees
Labels
Milestone

Comments

@rsc
Copy link
Contributor

@rsc rsc commented Jun 27, 2018

Pending CL 120998 is missing Subversion zip support. Need to add that.

@gopherbot gopherbot added this to the vgo milestone Jun 27, 2018
@rsc rsc modified the milestones: vgo, Go1.11 Jul 12, 2018
@rsc rsc added the modules label Jul 12, 2018
@rsc rsc changed the title x/vgo: add subversion zip support cmd/go: add subversion zip support Jul 12, 2018
@rsc

This comment has been minimized.

Copy link
Contributor Author

@rsc rsc commented Aug 17, 2018

Will have to deal with this in Go 1.12.

@rsc rsc modified the milestones: Go1.11, Go1.12 Aug 17, 2018
@bcmills bcmills modified the milestones: Go1.12, Go1.13 Oct 24, 2018
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Dec 10, 2018

Change https://golang.org/cl/153458 mentions this issue: cmd/go/internal/modfetch/codehost: return VCSError for unimplemented functions and malformed responses

gopherbot pushed a commit that referenced this issue Dec 11, 2018
…functions and malformed responses

Updates #28943
Updates #26092

Change-Id: I07af2731ef5af046b9f7c7280ccb3976cdf41ca4
Reviewed-on: https://go-review.googlesource.com/c/153458
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
@rsc rsc removed the release-blocker label May 9, 2019
@rsc rsc modified the milestones: Go1.13, Go1.14 May 9, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@bcmills bcmills modified the milestones: Backlog, Go1.14 Oct 10, 2019
@bcmills bcmills removed the early-in-cycle label Oct 15, 2019
@bcmills bcmills self-assigned this Oct 15, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Oct 24, 2019

Change https://golang.org/cl/203277 mentions this issue: cmd/go/internal/modfetch/codehost: remove invariantly-empty return value from Repo.ReadZip

gopherbot pushed a commit that referenced this issue Oct 24, 2019
…lue from Repo.ReadZip

Previously, codehost.Repo.ReadZip returned an 'actualSubdir' value
that was the empty string in all current implementations.

Updates #26092

Change-Id: I6708dd0f13ba88bcf1a1fb405e9d818fd6f9197e
Reviewed-on: https://go-review.googlesource.com/c/go/+/203277
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Oct 25, 2019

Change https://golang.org/cl/203497 mentions this issue: cmd/go: implement svn support in module mode

@bcmills

This comment has been minimized.

Copy link
Member

@bcmills bcmills commented Oct 25, 2019

Fixed in 1.14.

@bcmills bcmills closed this Oct 25, 2019
gopherbot pushed a commit that referenced this issue Oct 25, 2019
mod_get_svn passes, and I also tested this manually on a real-world svn-hosted package:

	example.com$ go mod init example.com
	go: creating new go.mod: module example.com

	example.com$ GOPROXY=direct GONOSUMDB=llvm.org go get -d llvm.org/llvm/bindings/go/llvm
	go: finding llvm.org/llvm latest
	go: finding llvm.org/llvm/bindings/go/llvm latest
	go: downloading llvm.org/llvm v0.0.0-20191022153947-000000375505
	go: extracting llvm.org/llvm v0.0.0-20191022153947-000000375505

	example.com$ go list llvm.org/llvm/bindings/...
	llvm.org/llvm/bindings/go
	llvm.org/llvm/bindings/go/llvm

Fixes #26092

Change-Id: Iefe2151b82a0225c73bb6f8dd7cd8a352897d4c0
Reviewed-on: https://go-review.googlesource.com/c/go/+/203497
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.