Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
net/http: k8s spdy TestUpgradeResponse broken in Go 1.11 #26161
Trying "make test" in Kubernetes with Go 1.11, and ran into a problem in one test.
Note that the test doesn't use hardly any Kubernetes stuff (this is a very low-level package in the Kubernetes graph), so it can be run standalone on Mac etc., using plain go tools:
Using Go 1.10 everything is OK:
Using recent master (257d6c4, Thu Jun 28):
That test is sending an HTTP request header that includes:
The server is sending back a header with WriteHeader and then hijacks the connection.
The test expects the client to get back a 101 (switching protocols) response.
The server in the test returns only:
In particular, it does not satisfy the GET request.
So the test server is not following the spec and d88b137 is doing the right thing according to the spec, but causes breakage to things that rely on the old incorrect behavior.
(If we don’t revert, some coordination between the libraries may be required. I'm going to look at the k8s test a bit more to see if I can get it to work with and without d88b137.)