Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/http2: ignore unknown 1xx responses like HTTP/1 #26189

Closed
bradfitz opened this issue Jul 2, 2018 · 3 comments
Closed

x/net/http2: ignore unknown 1xx responses like HTTP/1 #26189

bradfitz opened this issue Jul 2, 2018 · 3 comments
Assignees
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Jul 2, 2018

We should do the same as #17739 but for http2.Transport, so HTTP/1 and HTTP/2 are in sync behavior-wise for Go 1.11.

@bradfitz bradfitz added the NeedsFix label Jul 2, 2018
@bradfitz bradfitz added this to the Go1.11 milestone Jul 2, 2018
@bradfitz bradfitz self-assigned this Jul 2, 2018
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jul 12, 2018

Change https://golang.org/cl/123615 mentions this issue: http2: ignore unknown 1xx responses like HTTP/1

gopherbot pushed a commit to golang/net that referenced this issue Jul 12, 2018
Updates golang/go#26189 (fixes after vendor into std)
Updates golang/go#17739

Change-Id: I076cdbb57841b7dbbaa764d11240913bc3a8b05d
Reviewed-on: https://go-review.googlesource.com/123615
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jul 12, 2018

Change https://golang.org/cl/123675 mentions this issue: http2: fix bug in earlier CL 123615

gopherbot pushed a commit to golang/net that referenced this issue Jul 12, 2018
I both forgot that this list could contain duplicates, and I had
forgot to run the net/http tests against CL 123615 before mailing it,
which ended up catching this bug.

The diff of this file from the commit before CL 123615 (a45b4ab^ ==
cffdcf6) to this commit is:

    https://gist.github.com/bradfitz/0b7abf8fa421515aed9c4d55ce3a1994

... effectively reverting much of CL 123615 and just moving the 1xx
handling down lower.

Updates golang/go#26189 (fixes after vendor into std)
Updates golang/go#17739

Change-Id: Ib63060b0bb9721883b4b91a983b6e117994faeb9
Reviewed-on: https://go-review.googlesource.com/123675
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jul 12, 2018

Change https://golang.org/cl/123676 mentions this issue: net/http: update bundled http2

@gopherbot gopherbot closed this in 71d2908 Jul 12, 2018
@golang golang locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.