Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/http2: fragile TestServerHandlerConnectionClose #26190

Closed
mikioh opened this issue Jul 2, 2018 · 3 comments
Closed

x/net/http2: fragile TestServerHandlerConnectionClose #26190

mikioh opened this issue Jul 2, 2018 · 3 comments

Comments

@mikioh
Copy link
Contributor

@mikioh mikioh commented Jul 2, 2018

See https://storage.googleapis.com/go-build-log/28f9b880/windows-386-2008_897ede7f.log and https://storage.googleapis.com/go-build-log/28f9b880/linux-amd64_0ac7746a.log; it's pretty easy to reproduce with the following:

go test -v -run TestServerHandlerConnectionClose -count 100
@mikioh mikioh added this to the Unplanned milestone Jul 2, 2018
@fraenkel

This comment has been minimized.

Copy link
Contributor

@fraenkel fraenkel commented Jul 3, 2018

The test case asserts that GOAWAY will be seen before Headers. However, the code has racing channels which cannot guarantee this ordering.

@fraenkel

This comment has been minimized.

Copy link
Contributor

@fraenkel fraenkel commented Jul 3, 2018

@bradfitz This was a recent change you made. Are you trying to guarantee the GOAWAY before Headers?

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jul 5, 2018

Change https://golang.org/cl/122335 mentions this issue: http2: fix expected message order in TestServerHandlerConnectionClose

@golang golang locked and limited conversation to collaborators Jul 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.