New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/vet: reported typecheck errors not sorted by file position #26236

Open
rsc opened this Issue Jul 5, 2018 · 0 comments

Comments

Projects
None yet
4 participants
@rsc
Contributor

rsc commented Jul 5, 2018

Compare gc and vet typecheck errors:

$ go test
# golang.org/x/vgo2/vendor/cmd/go/internal/modfetch [golang.org/x/vgo2/vendor/cmd/go/internal/modfetch.test]
./coderepo.go:279:70: undefined: file2
./coderepo.go:294:8: no new variables on left side of :=
./coderepo.go:294:30: undefined: gomod
# golang.org/x/vgo2/vendor/cmd/go/internal/modfetch
./coderepo.go:294:30: undeclared name: gomod
./coderepo.go:294:8: no new variables on left side of :=
./coderepo.go:279:70: undeclared name: file2
vet: typecheck failures

(go test printing both sets at all is a different issue, but it is nice for seeing how they compare.)

It's weird that the errors from vet come out not sorted in file line order. They should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment